[ https://issues.apache.org/jira/browse/HBASE-17988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044836#comment-16044836 ]
Hadoop QA commented on HBASE-17988: ----------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 29s {color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 14s {color} | {color:blue} rubocop was not available. {color} | | {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 14s {color} | {color:blue} Ruby-lint was not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 62m 7s {color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 19s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 63m 20s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:757bf37 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12872173/HBASE-17988.002.patch | | JIRA Issue | HBASE-17988 | | Optional Tests | asflicense rubocop ruby_lint | | uname | Linux 96c9b79e6177 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh | | git revision | master / 7b40f4f | | modules | C: . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/7161/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > get-active-master.rb and draining_servers.rb no longer work > ----------------------------------------------------------- > > Key: HBASE-17988 > URL: https://issues.apache.org/jira/browse/HBASE-17988 > Project: HBase > Issue Type: Bug > Components: scripts > Affects Versions: 2.0.0 > Reporter: Mike Drob > Assignee: Chinmay Kulkarni > Priority: Critical > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.1.11, 1.2.7 > > Attachments: HBASE-17988.002.patch, HBASE-17988.patch > > > The scripts {{bin/get-active-master.rb}} and {{bin/draining_servers.rb}} no > longer work on current master branch. Here is an example error message: > {noformat} > $ bin/hbase-jruby bin/get-active-master.rb > NoMethodError: undefined method `masterAddressZNode' for > #<Java::OrgApacheHadoopHbaseZookeeper::ZooKeeperWatcher:0x1b0e9707> > <main> at bin/get-active-master.rb:35 > {noformat} > My initial probing suggests that this is likely due to movement that happened > in HBASE-16690. Perhaps instead of reworking the ruby, there is similar Java > functionality already existing somewhere. > Putting priority at critical since it's impossible to know whether users rely > on the scripts. -- This message was sent by Atlassian JIRA (v6.3.15#6346)