[
https://issues.apache.org/jira/browse/HBASE-18217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049971#comment-16049971
]
Phil Yang commented on HBASE-18217:
-----------------------------------
Time limit is half of timeout, see RSRpcServices
> Correct comment errors in TestScannerHeartbeatMessages
> ------------------------------------------------------
>
> Key: HBASE-18217
> URL: https://issues.apache.org/jira/browse/HBASE-18217
> Project: HBase
> Issue Type: Bug
> Reporter: Xiang Li
> Assignee: Xiang Li
> Priority: Minor
>
> 1. For CLIENT_TIMEOUT
> {code}
> // Time, in milliseconds, that the client will wait for a response from the
> server before timing
> // out. This value is used server side to determine when it is necessary to
> send a heartbeat
> // message to the client. Time limit will be 500 ms.
> private static int CLIENT_TIMEOUT = 1000;
> {code}
> I think “Time limit will be 500 ms.” should be removed
> 2. For DEFAULT_ROW_SLEEP_TIME
> Typo, "same" -> "some", in
> // In this test, we sleep after reading each row. So we should make sure
> after we get some number
> // of rows and sleep {color:red}same{color} times we must reach time limit,
> and do not timeout after next sleeping.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
