[ https://issues.apache.org/jira/browse/HBASE-18004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050960#comment-16050960 ]
stack commented on HBASE-18004: ------------------------------- Patch looks good [~huaxiang] This is just a minor optimization? > getRegionLocations needs to be called once in > ScannerCallableWithReplicas#call() > --------------------------------------------------------------------------------- > > Key: HBASE-18004 > URL: https://issues.apache.org/jira/browse/HBASE-18004 > Project: HBase > Issue Type: Improvement > Components: Client > Affects Versions: 2.0.0 > Reporter: huaxiang sun > Assignee: huaxiang sun > Priority: Minor > Attachments: HBASE-18004-master-001.patch, > HBASE-18004-master-002.patch > > > Look at this line, > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallableWithReplicas.java#L145 > It calls getRegionLocations() to get the primary region's locations. It's > usage is to figure out table's region replications. Since table's region > replication wont be changed until the table is disabled. It is safe to cache > this region replication. -- This message was sent by Atlassian JIRA (v6.4.14#64029)