[ 
https://issues.apache.org/jira/browse/HBASE-17840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051318#comment-16051318
 ] 

Mike Drob commented on HBASE-17840:
-----------------------------------

Patch v2 has several places where it is changing end of line whitespace. I'm 
all for cleaning it up, but thought I'd point it out in case you wanted to keep 
your changeset minimal.

Unclear what happens if a snapshot is taken, a new table materialized, and the 
original table deleted. I expect the new table to own the file, but I'm not 
sure any longer.

LGTM otherwise.

Maybe a diagram would be helpful, but that sounds pretty difficult so I 
wouldn't worry about it yet.

> Update book
> -----------
>
>                 Key: HBASE-17840
>                 URL: https://issues.apache.org/jira/browse/HBASE-17840
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>         Attachments: HBASE-17840.001.patch, HBASE-17840.002.patch
>
>
> Need to update the book to include the new feature.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to