[ https://issues.apache.org/jira/browse/HBASE-18234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062122#comment-16062122 ]
Hadoop QA commented on HBASE-18234: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 8 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 28s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 54s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 44s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 43s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m 16s {color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s {color} | {color:blue} Skipped patched modules with no Java source: . {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 1s {color} | {color:red} hbase-client in master has 4 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 58s {color} | {color:red} hbase-client in master has 4 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 58s {color} | {color:red} hbase-server in master has 10 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 50s {color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 3m 36s {color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 1m 47s {color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 47s {color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 18s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m 9s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s {color} | {color:red} The patch has 178 line(s) that end in whitespace. Use git apply --whitespace=fix. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 12s {color} | {color:red} The patch causes 15 errors with Hadoop v2.6.1. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 12s {color} | {color:red} The patch causes 15 errors with Hadoop v2.6.2. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m 15s {color} | {color:red} The patch causes 15 errors with Hadoop v2.6.3. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 8m 14s {color} | {color:red} The patch causes 15 errors with Hadoop v2.6.4. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 10m 14s {color} | {color:red} The patch causes 15 errors with Hadoop v2.6.5. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 12m 15s {color} | {color:red} The patch causes 15 errors with Hadoop v2.7.1. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 14m 12s {color} | {color:red} The patch causes 15 errors with Hadoop v2.7.2. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 16m 11s {color} | {color:red} The patch causes 15 errors with Hadoop v2.7.3. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 18m 16s {color} | {color:red} The patch causes 15 errors with Hadoop v3.0.0-alpha3. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s {color} | {color:blue} Skipped patched modules with no Java source: . {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 24s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 19s {color} | {color:red} hbase-client generated 8 new + 1 unchanged - 1 fixed = 9 total (was 2) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 2m 33s {color} | {color:red} root generated 8 new + 24 unchanged - 0 fixed = 32 total (was 24) {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 31s {color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 124m 40s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 131m 33s {color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 55s {color} | {color:red} The patch generated 1 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 320m 1s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.replication.regionserver.TestReplicator | | | hadoop.hbase.client.TestAsyncRegionAdminApi | | | hadoop.hbase.replication.regionserver.TestReplicator | | | hadoop.hbase.client.TestAsyncRegionAdminApi | | Timed out junit tests | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer | | | org.apache.hadoop.hbase.master.TestRestartCluster | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12874374/HBASE-18234.master.009.patch | | JIRA Issue | HBASE-18234 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 5886ead2179a 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 96aca6b | | Default Java | 1.8.0_131 | | findbugs | v3.1.0-RC1 | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/7314/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/7314/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/7314/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html | | mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/7314/artifact/patchprocess/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/PreCommit-HBASE-Build/7314/artifact/patchprocess/patch-compile-root.txt | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/7314/artifact/patchprocess/patch-compile-root.txt | | whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/7314/artifact/patchprocess/whitespace-eol.txt | | javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/7314/artifact/patchprocess/diff-javadoc-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/7314/artifact/patchprocess/diff-javadoc-javadoc-root.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/7314/artifact/patchprocess/patch-unit-hbase-server.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/7314/artifact/patchprocess/patch-unit-root.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/7314/artifact/patchprocess/patch-unit-hbase-server.txt https://builds.apache.org/job/PreCommit-HBASE-Build/7314/artifact/patchprocess/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/7314/testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-HBASE-Build/7314/artifact/patchprocess/patch-asflicense-problems.txt | | modules | C: hbase-client hbase-server . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/7314/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Revisit the async admin api > --------------------------- > > Key: HBASE-18234 > URL: https://issues.apache.org/jira/browse/HBASE-18234 > Project: HBase > Issue Type: Sub-task > Components: Client > Reporter: Guanghao Zhang > Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18234.master.001.patch, > HBASE-18234.master.002.patch, HBASE-18234.master.003.patch, > HBASE-18234.master.004.patch, HBASE-18234.master.005.patch, > HBASE-18234.master.006.patch, HBASE-18234.master.006.patch, > HBASE-18234.master.006.patch, HBASE-18234.master.007.patch, > HBASE-18234.master.008.patch, HBASE-18234.master.009.patch > > > 1. Update the balance method name. > balancer -> balance > setBalancerRunning -> setBalancerOn > isBalancerEnabled -> isBalancerOn > 2. Use HRegionLocation instead of Pair<HRegionInfo, ServerName> > 3. Remove the closeRegionWithEncodedRegionName method. Because all other api > can handle region name or encoded region name both. So don't need a method > for encoded name. > 4. Unify the region name parameter's type to byte[]. And region name may be > full name or encoded name. > 5. Unify the server name parameter's type to ServerName. For smoe api, it > support null for server name. So use Optional<ServerName> instead. > 6. Unify the table name parameter's type to TableName. -- This message was sent by Atlassian JIRA (v6.4.14#64029)