[ 
https://issues.apache.org/jira/browse/HBASE-18264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068552#comment-16068552
 ] 

stack commented on HBASE-18264:
-------------------------------

Went through the patch and left comments on review board. Patch is great.  
Patch is hard to test. We should just commit and watch it reverting if problem.

I compared versions on plugins in 
https://svn.apache.org/viewvc/maven/pom/tags/apache-18/pom.xml?view=markup and 
the apache pom lags.  Lets try make do w/ the apache pom version I'd say unless 
we explicitly rely on some feature in a newer version of a plugin. I say this 
because who knows, there might be some issue around artifact publish time 
because some new version of the wagon wheel plugin does something the apache 
repository doesn't like; seems unlikely but would be hell if it happened.  
Looking at the list of plugins in the apache pom, IMO, the only plugins worth 
improving on if there are newer versions are:

maven-compiler-plugin
maven-failsafe-plugin
maven-jar-plugin
maven-surefire-plugin
apache-rat-plugin

I think it would be good to update  note at head of the hbase parent pom to 
list interesting facts like our desire that plugin version get listed in the 
property section and add url to the apache pom with a note that we inherit 
plugin versions from it.

Nice one Peter.


> Update pom plugins
> ------------------
>
>                 Key: HBASE-18264
>                 URL: https://issues.apache.org/jira/browse/HBASE-18264
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>            Assignee: Peter Somogyi
>             Fix For: 2.0.0, 3.0.0
>
>         Attachments: HBASE-18264.master.001.patch
>
>
> A bunch are old. Lets update. [~balazs.meszaros] you want to have a go at 
> this sir?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to