[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181757#comment-13181757
]
jirapos...@reviews.apache.org commented on HBASE-4608:
------------------------------------------------------
bq. On 2012-01-02 23:39:38, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java, line
1655
bq. > <https://reviews.apache.org/r/2740/diff/5/?file=66009#file66009line1655>
bq. >
bq. > Should there be disableCompression ?
Compression is always enabled if config. Otherwise decompressor won't know
whether to try to decompress the log or not.
bq. On 2012-01-02 23:39:38, Ted Yu wrote:
bq. >
src/main/java/org/apache/hadoop/hbase/regionserver/wal/SimpleDictionary.java,
line 2
bq. > <https://reviews.apache.org/r/2740/diff/5/?file=66013#file66013line2>
bq. >
bq. > Remove this year line, please.
Done.
bq. On 2012-01-02 23:39:38, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/regionserver/wal/Compressor.java,
line 137
bq. > <https://reviews.apache.org/r/2740/diff/5/?file=66008#file66008line137>
bq. >
bq. > Add javadoc for the parameters, please.
Added.
bq. On 2012-01-02 23:39:38, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/regionserver/wal/Compressor.java,
line 1
bq. > <https://reviews.apache.org/r/2740/diff/5/?file=66008#file66008line1>
bq. >
bq. > License, please.
Done
bq. On 2012-01-02 23:39:38, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/HConstants.java, line 579
bq. > <https://reviews.apache.org/r/2740/diff/5/?file=66005#file66005line579>
bq. >
bq. > This name may refer to the compression algorithm.
bq. > I think the word 'enable' should be part of the name.
fixed.
bq. On 2012-01-02 23:39:38, Ted Yu wrote:
bq. >
src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressedKeyValue.java,
line 2
bq. > <https://reviews.apache.org/r/2740/diff/5/?file=66006#file66006line2>
bq. >
bq. > No year needed.
fixed.
bq. On 2012-01-02 23:39:38, Ted Yu wrote:
bq. >
src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressedKeyValue.java,
line 51
bq. > <https://reviews.apache.org/r/2740/diff/5/?file=66006#file66006line51>
bq. >
bq. > This javadoc should be combined with above block.
fixed.
bq. On 2012-01-02 23:39:38, Ted Yu wrote:
bq. >
src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressedKeyValue.java,
line 87
bq. > <https://reviews.apache.org/r/2740/diff/5/?file=66006#file66006line87>
bq. >
bq. > Should read 'Compresses and ...'
fixed.
bq. On 2012-01-02 23:39:38, Ted Yu wrote:
bq. >
src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java,
line 1
bq. > <https://reviews.apache.org/r/2740/diff/5/?file=66007#file66007line1>
bq. >
bq. > Add license, please.
fixed.
- Li
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2740/#review4172
-----------------------------------------------------------
On 2012-01-07 01:25:20, Li Pi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2740/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-07 01:25:20)
bq.
bq.
bq. Review request for hbase, Eli Collins and Todd Lipcon.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HLog compression. Has unit tests and a command line tool for
compressing/decompressing.
bq.
bq.
bq. This addresses bug HBase-4608.
bq. https://issues.apache.org/jira/browse/HBase-4608
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/HConstants.java 5120a3c
bq.
src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressedKeyValue.java
PRE-CREATION
bq.
src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/Compressor.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 24407af
bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogKey.java
f067221
bq.
src/main/java/org/apache/hadoop/hbase/regionserver/wal/LRUDictionary.java
PRE-CREATION
bq.
src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogReader.java
d9cd6de
bq.
src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java
cbef70f
bq.
src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALDictionary.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEdit.java
e1117ef
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLRUDictionary.java
PRE-CREATION
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java
59910bf
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplayCompressed.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2740/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Li
bq.
bq.
> HLog Compression
> ----------------
>
> Key: HBASE-4608
> URL: https://issues.apache.org/jira/browse/HBASE-4608
> Project: HBase
> Issue Type: New Feature
> Reporter: Li Pi
> Assignee: Li Pi
> Attachments: 4608v1.txt, 4608v5.txt, 4608v6.txt, 4608v7.txt
>
>
> The current bottleneck to HBase write speed is replicating the WAL appends
> across different datanodes. We can speed up this process by compressing the
> HLog. Current plan involves using a dictionary to compress table name, region
> id, cf name, and possibly other bits of repeated data. Also, HLog format may
> be changed in other ways to produce a smaller HLog.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
