[
https://issues.apache.org/jira/browse/HBASE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181779#comment-13181779
]
Zhihong Yu commented on HBASE-5136:
-----------------------------------
Thanks for the review, Prakash.
So the suggestion is to add finally block to splitLogDistributed().
Here is the implementation for cleanup() where stateTime would be set to
current time:
{code}
public void cleanup() {
if (state == State.RUNNING) {
setState(State.ABORTED);
}
}
{code}
TaskMonitor hardcodes expiration timeout as 60 seconds:
{code}
private static final long EXPIRATION_TIME = 60*1000;
{code}
The suggested approach would produce partially confusing result because there
might be multiple MonitoredTask instances for the same logDirs within 60 second
period.
Please correct me if my interpretation of the task monitoring is wrong.
> Redundant MonitoredTask instances in case of distributed log splitting retry
> ----------------------------------------------------------------------------
>
> Key: HBASE-5136
> URL: https://issues.apache.org/jira/browse/HBASE-5136
> Project: HBase
> Issue Type: Task
> Reporter: Zhihong Yu
> Assignee: Zhihong Yu
> Attachments: 5136.txt
>
>
> In case of log splitting retry, the following code would be executed multiple
> times:
> {code}
> public long splitLogDistributed(final List<Path> logDirs) throws
> IOException {
> MonitoredTask status = TaskMonitor.get().createStatus(
> "Doing distributed log split in " + logDirs);
> {code}
> leading to multiple MonitoredTask instances.
> User may get confused by multiple distributed log splitting entries for the
> same region server on master UI
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
