[ https://issues.apache.org/jira/browse/HBASE-18406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095461#comment-16095461 ]
Umesh Agashe commented on HBASE-18406: -------------------------------------- ship it! [~syuanjiang], can you push this? > In ServerCrashProcedure.java start(MasterProcedureEnv) is a no-op > ----------------------------------------------------------------- > > Key: HBASE-18406 > URL: https://issues.apache.org/jira/browse/HBASE-18406 > Project: HBase > Issue Type: Bug > Reporter: Alex Leblang > Assignee: Alex Leblang > Attachments: HBASE-18406.master.001.patch, > HBASE-18406.master.002.patch > > > The comments above this method explain that it exists to set configs and > return, however, no configs are set in the method. > As you can see here: > https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java#L210-L214 > > It is only ever called here: > https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java#L142 -- This message was sent by Atlassian JIRA (v6.4.14#64029)