[ https://issues.apache.org/jira/browse/HBASE-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100521#comment-16100521 ]
Appy edited comment on HBASE-18185 at 7/25/17 6:31 PM: ------------------------------------------------------- you can give assert*() fns a fail message as first argument. For eg. {{Assert.assertTrue("There are not enough victim servers: " + victimServers.size(), (liveCount + deadCount) < victimServers.size());}} --- Where you testing for killMetaRs, wouldn't you end up not killing servers some of the times? Shouldn't you add a while loop to make sure that at least one server is killed everytime. --- bq. The other problem with unbalanced monkey was that it kills that region which stores hbase:meta what we should avoid, so a new option (unbalance.action.kill.meta.rs) was introduced. why should we avoid that? That's legitimate failure scenario we should be testing. was (Author: appy): you can give assert*() fns a fail message as first argument. For eg. {{Assert.assertTrue("There are not enough victim servers: " + victimServers.size(), (liveCount + deadCount) < victimServers.size());}} -- Where you testing for killMetaRs, wouldn't you end up not killing servers some of the times? Shouldn't you add a while loop to make sure that at least one server is killed everytime. bq. The other problem with unbalanced monkey was that it kills that region which stores hbase:meta what we should avoid, so a new option (unbalance.action.kill.meta.rs) was introduced. why should we avoid that? That's legitimate failure scenario we should be testing. > IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails > with AssertionError > ----------------------------------------------------------------------------------------------- > > Key: HBASE-18185 > URL: https://issues.apache.org/jira/browse/HBASE-18185 > Project: HBase > Issue Type: Bug > Components: integration tests > Affects Versions: 2.0.0 > Reporter: Balazs Meszaros > Assignee: Balazs Meszaros > Priority: Minor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.2.7 > > Attachments: HBASE-18185-branch-1.v3.patch, > HBASE-18185-branch-1.v4.patch, HBASE-18185.v3.patch, HBASE-18185.v4.patch > > > We got the following error: > Exception in thread "main" java.lang.AssertionError: Verification failed with > error code 1 > at org.junit.Assert.fail(Assert.java:88) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.runIngestTest(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:217) > at > org.apache.hadoop.hbase.IntegrationTestIngest.internalRunIngestTest(IntegrationTestIngest.java:123) > at > org.apache.hadoop.hbase.IntegrationTestIngest.runTestFromCommandLine(IntegrationTestIngest.java:106) > at > org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:123) > at > org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) > at > org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedRequestsWithRegionReplicas.main(IntegrationTestTimeBoundedRequestsWithRegionReplicas.java:362) > The reason why we got it because another assertion fails in > UnbalanceKillAndRebalanceAction: > Exception in thread "Thread-57" java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at > org.apache.hadoop.hbase.chaos.actions.UnbalanceKillAndRebalanceAction.perform(UnbalanceKillAndRebalanceAction.java:60) -- This message was sent by Atlassian JIRA (v6.4.14#64029)