[
https://issues.apache.org/jira/browse/HBASE-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100823#comment-16100823
]
Amit Patel edited comment on HBASE-18395 at 7/25/17 9:37 PM:
-------------------------------------------------------------
As of [^HBASE-18395.HBASE-14070.HLC.003.patch], it doesn't yet include proper
mocking of the clocks in TestClockWithCluster and passing of the timestamp type
in the proto messages (see
[here|https://issues.apache.org/jira/browse/HBASE-14070?focusedCommentId=16100734&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16100734]
for details on the potential issue).
TODO: The tests in TestClockWithCluster would ideally also advance (for
example) the physical clock of the region server's HL clock by a fixed duration
before region assignment/unassignmnet and then assert that the master server's
clock was advanced by said fixed duration (and vice versa).
TODO: implement updating clock on region open with highest timestamp found in
region's files
was (Author: amit.patel):
As of [^HBASE-18395.HBASE-14070.HLC.003.patch], it doesn't yet include proper
mocking of the clocks in TestClockWithCluster and passing of the timestamp type
in the proto messages (see
[here|https://issues.apache.org/jira/browse/HBASE-14070?focusedCommentId=16100734&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16100734]
for details on the potential issue).
TODO: The tests in TestClockWithCluster would ideally also advance (for
example) the physical clock of the region server's HL clock by a fixed duration
before region assignment/unassignmnet and then assert that the master server's
clock was advanced by said fixed duration (and vice versa).
> Update clock on region open and close
> -------------------------------------
>
> Key: HBASE-18395
> URL: https://issues.apache.org/jira/browse/HBASE-18395
> Project: HBase
> Issue Type: Sub-task
> Reporter: Amit Patel
> Assignee: Amit Patel
> Priority: Minor
> Attachments: HBASE-18395.HBASE-14070.HLC.001.patch,
> HBASE-18395.HBASE-14070.HLC.002.patch, HBASE-18395.HBASE-14070.HLC.003.patch
>
>
> This task covers the patch for updating the clock on region opening and
> closing.
> The patch would include the following:
> * Addition of a new protobuf message type that contains a field for a
> timestamp
> * Setting of timestamp field in building region open/close request and
> response messages
> * Updating the clock upon receiving message
> The patch for this task will be going against the
> [HBASE-14070.HLC|https://git-wip-us.apache.org/repos/asf?p=hbase.git;a=shortlog;h=refs/heads/HBASE-14070.HLC]
> branch with the intent that it would be added as a commit.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
