[ https://issues.apache.org/jira/browse/HBASE-18261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100974#comment-16100974 ]
Hadoop QA commented on HBASE-18261: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 4 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 29s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 15s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 20s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 11m 36s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 31s{color} | {color:green} master passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 59s{color} | {color:red} hbase-protocol-shaded in master has 27 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 45s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 16s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 11m 33s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 29m 37s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 12s{color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 47s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 31s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 0s{color} | {color:green} hbase-procedure in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 75m 17s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 39s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}157m 37s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hbase-server | | | Exception is caught when Exception is not thrown in org.apache.hadoop.hbase.master.procedure.RecoverMetaProcedure.executeFromState(MasterProcedureEnv, MasterProcedureProtos$RecoverMetaState) At RecoverMetaProcedure.java:is not thrown in org.apache.hadoop.hbase.master.procedure.RecoverMetaProcedure.executeFromState(MasterProcedureEnv, MasterProcedureProtos$RecoverMetaState) At RecoverMetaProcedure.java:[line 144] | | Failed junit tests | hadoop.hbase.master.assignment.TestAssignmentManager | | | hadoop.hbase.master.procedure.TestServerCrashProcedure | | Timed out junit tests | org.apache.hadoop.hbase.mapreduce.TestWALPlayer | | | org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence | | | org.apache.hadoop.hbase.mapreduce.TestHRegionPartitioner | | | org.apache.hadoop.hbase.mapreduce.TestTableInputFormat | | | org.apache.hadoop.hbase.client.TestFromClientSide | | | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries | | | org.apache.hadoop.hbase.backup.TestRemoteBackup | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 | | | org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook | | | org.apache.hadoop.hbase.client.TestAsyncTableBatch | | | org.apache.hadoop.hbase.quotas.TestSnapshotQuotaObserverChore | | | org.apache.hadoop.hbase.TestFullLogReconstruction | | | org.apache.hadoop.hbase.coprocessor.TestCoprocessorMetrics | | | org.apache.hadoop.hbase.TestMultiVersions | | | org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi | | | org.apache.hadoop.hbase.client.TestAsyncNonMetaRegionLocator | | | org.apache.hadoop.hbase.quotas.TestQuotaStatusRPCs | | | org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint | | | org.apache.hadoop.hbase.wal.TestWALFiltering | | | org.apache.hadoop.hbase.backup.TestFullBackup | | | org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi | | | org.apache.hadoop.hbase.filter.TestFilterWrapper | | | org.apache.hadoop.hbase.security.access.TestAccessController2 | | | org.apache.hadoop.hbase.replication.TestReplicationStateHBaseImpl | | | org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi | | | org.apache.hadoop.hbase.quotas.TestMasterSpaceQuotaObserver | | | org.apache.hadoop.hbase.mapreduce.TestCellCounter | | | org.apache.hadoop.hbase.TestZooKeeper | | | org.apache.hadoop.hbase.client.TestAsyncTableAdminApi | | | org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream | | | org.apache.hadoop.hbase.wal.TestWALSplitCompressed | | | org.apache.hadoop.hbase.client.TestAsyncToolAdminApi | | | org.apache.hadoop.hbase.client.TestScannersFromClientSide2 | | | org.apache.hadoop.hbase.filter.TestFilterWithScanLimits | | | org.apache.hadoop.hbase.filter.TestScanRowPrefix | | | org.apache.hadoop.hbase.coprocessor.TestMasterObserver | | | org.apache.hadoop.hbase.client.TestServerBusyException | | | org.apache.hadoop.hbase.quotas.TestRegionSizeUse | | | org.apache.hadoop.hbase.backup.TestBackupDescribe | | | org.apache.hadoop.hbase.master.balancer.TestFavoredStochasticLoadBalancer | | | org.apache.hadoop.hbase.client.TestMetaWithReplicas | | | org.apache.hadoop.hbase.client.TestClientTimeouts | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService | | | org.apache.hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput | | | org.apache.hadoop.hbase.backup.TestRepairAfterFailedDelete | | | org.apache.hadoop.hbase.util.TestHBaseFsckEncryption | | | org.apache.hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes | | | org.apache.hadoop.hbase.backup.TestBackupDeleteRestore | | | org.apache.hadoop.hbase.client.TestFromClientSide3 | | | org.apache.hadoop.hbase.master.assignment.TestAssignmentOnRSCrash | | | org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput | | | org.apache.hadoop.hbase.master.TestSplitLogManager | | | org.apache.hadoop.hbase.TestClusterBootOrder | | | org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport | | | org.apache.hadoop.hbase.client.TestScannerTimeout | | | org.apache.hadoop.hbase.master.TestRollingRestart | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer | | | org.apache.hadoop.hbase.quotas.TestSpaceQuotas | | | org.apache.hadoop.hbase.TestJMXConnectorServer | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded | | | org.apache.hadoop.hbase.util.TestCoprocessorScanPolicy | | | org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders | | | org.apache.hadoop.hbase.backup.TestIncrementalBackupDeleteTable | | | org.apache.hadoop.hbase.backup.TestRemoteRestore | | | org.apache.hadoop.hbase.backup.TestFullBackupSet | | | org.apache.hadoop.hbase.master.TestDeadServer | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential | | | org.apache.hadoop.hbase.security.TestSecureIPC | | | org.apache.hadoop.hbase.backup.TestFullRestore | | | org.apache.hadoop.hbase.master.TestMasterShutdown | | | org.apache.hadoop.hbase.backup.TestBackupDelete | | | org.apache.hadoop.hbase.client.TestAdmin2 | | | org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner | | | org.apache.hadoop.hbase.client.TestAdmin1 | | | org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat2 | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsOpWithDifferentUsersNoACL | | | org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL | | | org.apache.hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | org.apache.hadoop.hbase.mob.TestExpiredMobFileCleaner | | | org.apache.hadoop.hbase.master.TestMaster | | | org.apache.hadoop.hbase.filter.TestFuzzyRowAndColumnRangeFilter | | | org.apache.hadoop.hbase.security.access.TestAccessControlFilter | | | org.apache.hadoop.hbase.TestAcidGuarantees | | | org.apache.hadoop.hbase.TestGlobalMemStoreSize | | | org.apache.hadoop.hbase.client.TestSnapshotMetadata | | | org.apache.hadoop.hbase.TestNamespace | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL | | | org.apache.hadoop.hbase.backup.TestIncrementalBackupWithFailures | | | org.apache.hadoop.hbase.client.TestCheckAndMutate | | | org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor | | | org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes | | | org.apache.hadoop.hbase.mapreduce.TestSyncTable | | | org.apache.hadoop.hbase.mapreduce.TestCopyTable | | | org.apache.hadoop.hbase.mapreduce.TestHashTable | | | org.apache.hadoop.hbase.client.TestEnableTable | | | org.apache.hadoop.hbase.client.TestReplicaWithCluster | | | org.apache.hadoop.hbase.quotas.TestSpaceQuotasWithSnapshots | | | org.apache.hadoop.hbase.backup.TestBackupDeleteWithFailures | | | org.apache.hadoop.hbase.util.TestRegionSplitter | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString | | | org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions | | | org.apache.hadoop.hbase.filter.TestMultiRowRangeFilter | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication | | | org.apache.hadoop.hbase.backup.TestFullBackupWithFailures | | | org.apache.hadoop.hbase.TestHBaseOnOtherDfsCluster | | | org.apache.hadoop.hbase.util.TestRegionMover | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths | | | org.apache.hadoop.hbase.security.access.TestCellACLs | | | org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache | | | org.apache.hadoop.hbase.snapshot.TestMobRestoreFlushSnapshotFromClient | | | org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreRegionReports | | | org.apache.hadoop.hbase.replication.TestReplicationTableBase | | | org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpointNoMaster | | | org.apache.hadoop.hbase.client.TestTimestampsFilter | | | org.apache.hadoop.hbase.TestIOFencing | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel | | | org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles | | | org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient | | | org.apache.hadoop.hbase.mapreduce.TestTimeRangeMapRed | | | org.apache.hadoop.hbase.mapreduce.TestImportExport | | | org.apache.hadoop.hbase.master.TestWarmupRegion | | | org.apache.hadoop.hbase.security.access.TestWithDisabledAuthorization | | | org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite | | | org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk | | | org.apache.hadoop.hbase.backup.TestBackupStatusProgress | | | org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | | org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClient | | | org.apache.hadoop.hbase.util.TestHBaseFsckMOB | | | org.apache.hadoop.hbase.coprocessor.TestRegionObserverBypass | | | org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas | | | org.apache.hadoop.hbase.client.TestMvccConsistentScanner | | | org.apache.hadoop.hbase.quotas.TestSuperUserQuotaPermissions | | | org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles | | | org.apache.hadoop.hbase.backup.TestRestoreBoundaryTests | | | org.apache.hadoop.hbase.client.TestTableSnapshotScanner | | | org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient | | | org.apache.hadoop.hbase.security.access.TestScanEarlyTermination | | | org.apache.hadoop.hbase.fs.TestBlockReorder | | | org.apache.hadoop.hbase.backup.TestBackupBoundaryTests | | | org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide | | | org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient | | | org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient | | | org.apache.hadoop.hbase.client.TestCloneSnapshotFromClientWithRegionReplicas | | | org.apache.hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels | | | org.apache.hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver | | | org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort | | | org.apache.hadoop.hbase.master.TestRegionPlacement2 | | | org.apache.hadoop.hbase.client.TestCloneSnapshotFromClient | | | org.apache.hadoop.hbase.util.TestConnectionCache | | | org.apache.hadoop.hbase.mapreduce.TestImportTSVWithTTLs | | | org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher | | | org.apache.hadoop.hbase.replication.TestMultiSlaveReplication | | | org.apache.hadoop.hbase.io.hfile.TestHFileBlock | | | org.apache.hadoop.hbase.backup.TestBackupRepair | | | org.apache.hadoop.hbase.wal.TestBoundedRegionGroupingStrategy | | | org.apache.hadoop.hbase.wal.TestWALFactory | | | org.apache.hadoop.hbase.backup.TestBackupMultipleDeletes | | | org.apache.hadoop.hbase.backup.TestIncrementalBackupWithBulkLoad | | | org.apache.hadoop.hbase.client.TestHTableMultiplexer | | | org.apache.hadoop.hbase.client.TestMobSnapshotFromClient | | | org.apache.hadoop.hbase.util.TestIdReadWriteLock | | | org.apache.hadoop.hbase.wal.TestFSHLogProvider | | | org.apache.hadoop.hbase.coprocessor.TestCoprocessorStop | | | org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd | | | org.apache.hadoop.hbase.mapreduce.TestTableSnapshotInputFormat | | | org.apache.hadoop.hbase.replication.regionserver.TestTableBasedReplicationSourceManagerImpl | | | org.apache.hadoop.hbase.client.TestScannersFromClientSide | | | org.apache.hadoop.hbase.client.TestAsyncAdminBuilder | | | org.apache.hadoop.hbase.replication.TestMasterReplication | | | org.apache.hadoop.hbase.replication.regionserver.TestReplicationSourceManagerZkImpl | | | org.apache.hadoop.hbase.master.assignment.TestSplitTableRegionProcedure | | | org.apache.hadoop.hbase.TestPartialResultsFromClientSide | | | org.apache.hadoop.hbase.client.TestSnapshotFromClient | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsOnNewVersionBehaviorTable | | | org.apache.hadoop.hbase.replication.TestReplicationSource | | | org.apache.hadoop.hbase.backup.TestFullBackupSetRestoreSet | | | org.apache.hadoop.hbase.io.TestFileLink | | | org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat | | | org.apache.hadoop.hbase.util.TestFSUtils | | | org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery | | | org.apache.hadoop.hbase.backup.TestBackupShowHistory | | | org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 | | | org.apache.hadoop.hbase.client.TestMobSnapshotCloneIndependence | | | org.apache.hadoop.hbase.mapreduce.TestImportTsv | | | org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers | | | org.apache.hadoop.hbase.wal.TestWALSplit | | | org.apache.hadoop.hbase.backup.TestIncrementalBackup | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 | | JIRA Issue | HBASE-18261 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12878910/hbase-18261.master.002.patch | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc | | uname | Linux b15fe90bc04e 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / c891642 | | Default Java | 1.8.0_131 | | findbugs | v3.1.0-RC3 | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/7786/artifact/patchprocess/branch-findbugs-hbase-protocol-shaded-warnings.html | | whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/7786/artifact/patchprocess/whitespace-eol.txt | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/7786/artifact/patchprocess/new-findbugs-hbase-server.html | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/7786/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/7786/testReport/ | | modules | C: hbase-protocol-shaded hbase-procedure hbase-server U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/7786/console | | Powered by | Apache Yetus 0.4.0 http://yetus.apache.org | This message was automatically generated. > [AMv2] Create new RecoverMetaProcedure and use it from ServerCrashProcedure > and HMaster.finishActiveMasterInitialization() > -------------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-18261 > URL: https://issues.apache.org/jira/browse/HBASE-18261 > Project: HBase > Issue Type: Improvement > Components: amv2 > Affects Versions: 2.0.0-alpha-1 > Reporter: Umesh Agashe > Assignee: Umesh Agashe > Fix For: 2.0.0-alpha-2 > > Attachments: hbase-18261.master.001.patch, > HBASE-18261.master.001.patch, hbase-18261.master.002.patch > > > When unit test > hbase.master.procedure.TestServerCrashProcedure#testRecoveryAndDoubleExecutionOnRsWithMeta() > is enabled and run several times, it fails intermittently. Cause is meta > recovery is done at two different places: > * ServerCrashProcedure.processMeta() > * HMaster.finishActiveMasterInitialization() > and its not coordinated. > When HMaster.finishActiveMasterInitialization() gets to submit splitMetaLog() > first and while its running call from ServerCrashProcedure.processMeta() > fails causing step to be retried again in a loop. > When ServerCrashProcedure.processMeta() submits splitMetaLog after > splitMetaLog from HMaster.finishActiveMasterInitialization() is finished, > success is returned without doing any work. > But if ServerCrashProcedure.processMeta() submits splitMetaLog request and > while its going HMaster.finishActiveMasterInitialization() submits it test > fails with exception. > [~stack] and I discussed the possible solution: > Create RecoverMetaProcedure and call it where required. Procedure framework > provides mutual exclusion and requires idempotence, which should fix the > problem. -- This message was sent by Atlassian JIRA (v6.4.14#64029)