[ 
https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104428#comment-16104428
 ] 

ramkrishna.s.vasudevan commented on HBASE-18448:
------------------------------------------------

{code}
if (LOG.isDebugEnabled()) {
2457                LOG.debug("Trying to refresh HFiles for " + pair.getFirst() 
+ ": " +
2458                            StringUtils.stringifyException(e));
2459              }
{code}
So when you don't find a region you just try to log it. Is this fine? Say if 
the region was split you will not do the refresh of it? And considering you 
want to do this manually how frequently do you do it? Is it like every 
configured amout of time or how is it? Patch generally looks good to me. 


> Added support for refreshing HFiles through API and shell
> ---------------------------------------------------------
>
>                 Key: HBASE-18448
>                 URL: https://issues.apache.org/jira/browse/HBASE-18448
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0, 1.3.1
>            Reporter: Ajay Jadhav
>            Assignee: Ajay Jadhav
>            Priority: Minor
>             Fix For: 1.4.0
>
>         Attachments: HBASE-18448.branch-1.001.patch, 
> HBASE-18448.branch-1.002.patch
>
>
> In the case where multiple HBase clusters are sharing a common rootDir, even 
> after flushing the data from
> one cluster doesn't mean that other clusters (replicas) will automatically 
> pick the new HFile. Through this patch,
> we are exposing the refresh HFiles API which when issued from a replica will 
> update the in-memory file handle list
> with the newly added file.
> This allows replicas to be consistent with the data written through the 
> primary cluster. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to