[ 
https://issues.apache.org/jira/browse/HBASE-18024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105547#comment-16105547
 ] 

Esteban Gutierrez commented on HBASE-18024:
-------------------------------------------

Got a fix for the test in TestWALMonotonicallyIncreasingSeqId which is fine. 
What is interesting is in TestStoreFileRefresherChore, which is what was 
uncovered while troubleshooting the issue that brought this JIRA. After my 
change HRegion.initialize() will not attempt to re-create the regioninfo file, 
but throwing an exception will cause the test to fail since the region replica 
cannot be instantiated. One option I've been thinking is to modify 
HRegion#initialize() to have an optional argument to initialize the region on 
the filesystem in order to skip writeRegionInfoOnFilesystem.

> HRegion#initializeRegionInternals should not re-create .hregioninfo file when 
> the region directory no longer exists
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-18024
>                 URL: https://issues.apache.org/jira/browse/HBASE-18024
>             Project: HBase
>          Issue Type: Bug
>          Components: Region Assignment, regionserver
>    Affects Versions: 2.0.0, 1.4.0, 1.3.1, 1.2.5
>            Reporter: Esteban Gutierrez
>            Assignee: Esteban Gutierrez
>         Attachments: HBASE-18024.001.patch
>
>
> When a RegionSever attempts to open a region, during initialization the RS 
> tries to open the {{<hbase.root.dir>/data/<table>/<region>/.hregioninfo}} 
> file, however if the {{.hregioninfofile}} doesn't exist, the RegionServer 
> will create a new one on {{HRegionFileSystem#checkRegionInfoOnFilesystem}}. A 
> side effect of that tools like hbck will incorrectly assume an inconsistency 
> due the presence of this new {{.hregioninfofile}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to