[ 
https://issues.apache.org/jira/browse/HBASE-18466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105690#comment-16105690
 ] 

Enis Soztutar commented on HBASE-18466:
---------------------------------------

We already have the do_not_retry information in the IOException class, and 
there is no need for the HBaseIOException class as in the patch. I fear that 
adding the DoNotRetryException will just add confusion over the java class 
DoNotRetryException, as well as IOException::do_not_retry(). Can you please do 
the patch without these new exceptions. If you need to throw a specific 
exception from the server side for the test, you can add a new exception in the 
test code. 

Other than that looks good. 

> [C++] Support handling exception in RpcTestServer
> -------------------------------------------------
>
>                 Key: HBASE-18466
>                 URL: https://issues.apache.org/jira/browse/HBASE-18466
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HBASE-18466.000.patch, HBASE-18466.001.patch
>
>
> In order simulate various error from servers,  exceptions should be handled 
> properly. The idea is to zip exception into hbase::Response in 
> RpcTestService, and Serialize response to folly::IOBuf and write it down the 
> pipeline.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to