[ 
https://issues.apache.org/jira/browse/HBASE-18490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109158#comment-16109158
 ] 

Ted Yu commented on HBASE-18490:
--------------------------------

private static void enableReplicationByModification(final TableName tableName)

Replace Replication with Replica (or Replicas) above. Replication has its own 
meaning.

Looks like setReplicas() should be modified to do the following:
{code}
    if (hTableDescriptor.getRegionReplication() > 1) {
      
ServerRegionReplicaUtil.setupRegionReplicaReplication(env.getMasterConfiguration());
    }
{code}
Thanks

> Modifying a table descriptor to enable replicas does not create replica 
> regions
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-18490
>                 URL: https://issues.apache.org/jira/browse/HBASE-18490
>             Project: HBase
>          Issue Type: Bug
>          Components: Region Assignment
>    Affects Versions: 1.3.1, 1.2.6, 2.0.0-alpha-1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: TestRegionReplicasWithRestartScenarios.java
>
>
> After creating a table, if we try to modify the table to enable region 
> replication, the new Htable Descriptor is not taken into account and the 
> table is enabled again with default single region.
> Ping [~enis], [~tedyu], [~devaraj].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to