[
https://issues.apache.org/jira/browse/HBASE-18125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125466#comment-16125466
]
Hadoop QA commented on HBASE-18125:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 4m
55s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} rubocop {color} | {color:green} 0m
7s{color} | {color:green} There were no new rubocop issues. {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green} 0m
4s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
37m 41s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m
6s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 56m 44s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18125 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12881497/HBASE-18125.patch |
| Optional Tests | asflicense javac javadoc unit rubocop ruby_lint |
| uname | Linux 12b755938691 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / e2b797b |
| Default Java | 1.8.0_144 |
| rubocop | v0.49.1 |
| ruby-lint | v2.3.1 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8071/testReport/ |
| modules | C: hbase-shell U: hbase-shell |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8071/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> HBase shell disregards spaces at the end of a split key in a split file
> -----------------------------------------------------------------------
>
> Key: HBASE-18125
> URL: https://issues.apache.org/jira/browse/HBASE-18125
> Project: HBase
> Issue Type: Bug
> Components: shell
> Affects Versions: 2.0.0, 1.3.1
> Reporter: Ashu Pachauri
> Assignee: Chenxi Tong
> Labels: beginner
> Fix For: 2.0.0, 1.3.1
>
> Attachments: HBASE-18125.patch
>
>
> When converting row keys to a printable string representation, Bytes class
> considers SPACE as a printable character, so it prints it out as it is. So,
> it's quite possible that a row key has a space at the end.
> When specifying split points in a file, the row keys are not quoted and the
> shell wrapper "admin.rb" strips any whitespace off the row keys:
> {code}
> File.foreach(splits_file) do |line|
> arg[SPLITS].push(line.strip())
> end
> {code}
> The correct approach is to use "chomp()" instead of "strip()" to just strip
> off carriage returns and newlines. We should assume that the hbase user is
> either using split points printed out by hbase itself (which will not have
> tabs) or is diligent enough to not use tabs at the end of a split point.
> What's worse is that it goes undetected and will result in undesirable split
> points.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
