[ https://issues.apache.org/jira/browse/HBASE-18573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129701#comment-16129701 ]
Xiang Li commented on HBASE-18573: ---------------------------------- Thanks Jerry and Chia-Ping Tsai for the review! > Update Append and Delete to use Mutation#getCellList(family) > ------------------------------------------------------------ > > Key: HBASE-18573 > URL: https://issues.apache.org/jira/browse/HBASE-18573 > Project: HBase > Issue Type: Improvement > Reporter: Xiang Li > Assignee: Xiang Li > Priority: Minor > Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3 > > Attachments: HBASE-18573.master.000.patch > > > In addxxx() of Put and Increment, Mutation#getCellList(family) is called to > get cell list from familyMap. But in the other 2 sub-class of Mutation: > Append and Delete, the logic like Mutation#getCellList(family) is used, like > {code} > List<Cell> list = familyMap.get(family); > if(list == null) { > list = new ArrayList<>(1); > } > {code} > in > {code} > public Delete addColumn(byte [] family, byte [] qualifier, long timestamp) > {code} > of Delete > We could make them to call Mutation#getCellList(family) to get better > encapsulation -- This message was sent by Atlassian JIRA (v6.4.14#64029)