[ 
https://issues.apache.org/jira/browse/HBASE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184294#comment-13184294
 ] 

Jean-Daniel Cryans commented on HBASE-4440:
-------------------------------------------

bq. whether we use presplit option or not, table has to be recreated for all 
write-mode tests.

No, it shouldn't be different from the default behavior of not recreating the 
table.

bq. or pre-split should try to split the table without re-creating it.

It should not.

Code speaks more than words, here's what I'm using for testing 0.92:

{code}
  private boolean checkTable(HBaseAdmin admin) throws IOException {
    HTableDescriptor tableDescriptor = getTableDescriptor();
    boolean tableExists = admin.tableExists(tableDescriptor.getName());
    if (!tableExists) {
      if (this.presplitRegions > 0) {
        byte[][] splits = getSplits();
        for (int i=0; i < splits.length; i++) {
          LOG.debug(" split " + i + ": " + Bytes.toStringBinary(splits[i]));
        }
        admin.createTable(tableDescriptor, splits);
        LOG.info ("Table created with " + this.presplitRegions + " splits");
      }
      else {
        admin.createTable(tableDescriptor);
        LOG.info("Table " + tableDescriptor + " created");
      }
    }
    return !tableExists;
  }
{code}
                
> add an option to presplit table to PerformanceEvaluation
> --------------------------------------------------------
>
>                 Key: HBASE-4440
>                 URL: https://issues.apache.org/jira/browse/HBASE-4440
>             Project: HBase
>          Issue Type: Improvement
>          Components: util
>            Reporter: Sujee Maniyam
>            Assignee: Sujee Maniyam
>            Priority: Minor
>              Labels: benchmark
>             Fix For: 0.94.0
>
>         Attachments: PerformanceEvaluation.java, 
> PerformanceEvaluation_HBASE_4440.patch, 
> PerformanceEvaluation_HBASE_4440_2.patch
>
>
> PerformanceEvaluation a quick way to 'benchmark' a HBase cluster.  The 
> current 'write*' operations do not pre-split the table.  Pre splitting the 
> table will really boost the insert performance.
> It would be nice to have an option to enable pre-splitting table before the 
> inserts begin.
> it would look something like:
> (a) hbase ...PerformanceEvaluation   --presplit=10 <other options>
> (b) hbase ...PerformanceEvaluation   --presplit <other options>
> (b) will try to presplit the table on some default value (say number of 
> region servers)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to