[ https://issues.apache.org/jira/browse/HBASE-18634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134153#comment-16134153 ]
Reid Chan commented on HBASE-18634: ----------------------------------- Yea, after patch [HBASE-18511|https://issues.apache.org/jira/browse/HBASE-18511] i think {code} + // By default, HMaster don't carry any regions so it won't report its load. + // Hence, it won't be in the server list. + Assert.assertEquals(status.getServers().size(), numRs); {code} is right, besides that, these codes {code} - while (!DEAD.isStopped()) { + while (rst.isAlive()) { Thread.sleep(500); } {code} make this test stable, not like previous version... lgtm. > Fix client.TestClientClusterStatus > ---------------------------------- > > Key: HBASE-18634 > URL: https://issues.apache.org/jira/browse/HBASE-18634 > Project: HBase > Issue Type: Bug > Components: test > Reporter: Chia-Ping Tsai > Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > Attachments: HBASE-18634.v0.patch > > > After HBASE-18511, the master doesn't carry any regions by default. Hence, > The active master doesn't report its load because the report thread is > sleeping in waitForMasterActive(). > {code} > protected void waitForMasterActive(){ > boolean tablesOnMaster = LoadBalancer.isTablesOnMaster(conf); > while (!(tablesOnMaster && activeMaster) && !isStopped() && !isAborted()) > { > sleeper.sleep(); > } > } > {code} > In conclusion, the ClusterStatue#getServers won't contain the master name. -- This message was sent by Atlassian JIRA (v6.4.14#64029)