[ https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136918#comment-16136918 ]
Hadoop QA commented on HBASE-17442: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 17s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 10s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 54s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m 40s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m 20s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 54s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 6s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 43m 54s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 2s{color} | {color:green} hbase-client in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 16s{color} | {color:green} hbase-replication in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green}159m 16s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red}102m 12s{color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m 49s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}368m 37s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed out junit tests | org.apache.hadoop.hbase.regionserver.TestSplitLogWorker | | | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy | | | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId | | | org.apache.hadoop.hbase.regionserver.TestCompaction | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 | | | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries | | | org.apache.hadoop.hbase.backup.TestRemoteBackup | | | org.apache.hadoop.hbase.regionserver.TestTimestampFilterSeekHint | | | org.apache.hadoop.hbase.TestHBaseTestingUtility | | | org.apache.hadoop.hbase.wal.TestWALFiltering | | | org.apache.hadoop.hbase.backup.TestFullBackup | | | org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream | | | org.apache.hadoop.hbase.master.TestGetInfoPort | | | org.apache.hadoop.hbase.TestZooKeeper | | | org.apache.hadoop.hbase.wal.TestWALSplitCompressed | | | org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence | | | org.apache.hadoop.hbase.regionserver.TestColumnSeeking | | | org.apache.hadoop.hbase.regionserver.TestRegionServerAbort | | | org.apache.hadoop.hbase.quotas.TestRegionSizeUse | | | org.apache.hadoop.hbase.backup.TestBackupDescribe | | | org.apache.hadoop.hbase.regionserver.TestRegionIncrement | | | org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort | | | org.apache.hadoop.hbase.backup.TestRepairAfterFailedDelete | | | org.apache.hadoop.hbase.util.TestHBaseFsckEncryption | | | org.apache.hadoop.hbase.master.TestTableStateManager | | | org.apache.hadoop.hbase.backup.TestBackupDeleteRestore | | | org.apache.hadoop.hbase.master.assignment.TestAssignmentOnRSCrash | | | org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures | | | org.apache.hadoop.hbase.regionserver.TestWalAndCompactingMemStoreFlush | | | org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput | | | org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable | | | org.apache.hadoop.hbase.master.TestSplitLogManager | | | org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS | | | org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer | | | org.apache.hadoop.hbase.master.TestRollingRestart | | | org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss | | | org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders | | | org.apache.hadoop.hbase.TestJMXConnectorServer | | | org.apache.hadoop.hbase.wal.TestSecureWAL | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded | | | org.apache.hadoop.hbase.backup.TestFullBackupSet | | | org.apache.hadoop.hbase.backup.TestRemoteRestore | | | org.apache.hadoop.hbase.backup.TestIncrementalBackupDeleteTable | | | org.apache.hadoop.hbase.regionserver.TestRegionServerReportForDuty | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential | | | org.apache.hadoop.hbase.master.TestMasterShutdown | | | org.apache.hadoop.hbase.regionserver.wal.TestLogRolling | | | org.apache.hadoop.hbase.backup.TestFullRestore | | | org.apache.hadoop.hbase.regionserver.throttle.TestCompactionWithThroughputController | | | org.apache.hadoop.hbase.backup.TestBackupDelete | | | org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush | | | org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner | | | org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL | | | org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat2 | | | org.apache.hadoop.hbase.regionserver.wal.TestLogRollingNoCluster | | | org.apache.hadoop.hbase.regionserver.TestJoinedScanners | | | org.apache.hadoop.hbase.regionserver.wal.TestAsyncFSWAL | | | org.apache.hadoop.hbase.backup.TestIncrementalBackupMergeWithFailures | | | org.apache.hadoop.hbase.master.cleaner.TestLogsCleaner | | | org.apache.hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController | | | org.apache.hadoop.hbase.regionserver.TestCompactingToCellFlatMapMemStore | | | org.apache.hadoop.hbase.mob.TestExpiredMobFileCleaner | | | org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster | | | org.apache.hadoop.hbase.TestAcidGuarantees | | | org.apache.hadoop.hbase.TestGlobalMemStoreSize | | | org.apache.hadoop.hbase.regionserver.TestCompactionWithCoprocessor | | | org.apache.hadoop.hbase.io.hfile.TestSeekBeforeWithInlineBlocks | | | org.apache.hadoop.hbase.master.assignment.TestRegionStates | | | org.apache.hadoop.hbase.backup.TestIncrementalBackupWithFailures | | | org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks | | | org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster | | | org.apache.hadoop.hbase.regionserver.TestCompoundBloomFilter | | | org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoadWithOldClient | | | org.apache.hadoop.hbase.regionserver.TestRecoveredEdits | | | org.apache.hadoop.hbase.backup.TestBackupDeleteWithFailures | | | org.apache.hadoop.hbase.master.procedure.TestMasterProcedureSchedulerConcurrency | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString | | | org.apache.hadoop.hbase.backup.TestFullBackupWithFailures | | | org.apache.hadoop.hbase.mapreduce.TestWALRecordReader | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication | | | org.apache.hadoop.hbase.TestHBaseOnOtherDfsCluster | | | org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache | | | org.apache.hadoop.hbase.replication.TestReplicationTableBase | | | org.apache.hadoop.hbase.master.TestRestartCluster | | | org.apache.hadoop.hbase.regionserver.TestCompactingMemStore | | | org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreRegionReports | | | org.apache.hadoop.hbase.TestIOFencing | | | org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing | | | org.apache.hadoop.hbase.regionserver.TestHRegion | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel | | | org.apache.hadoop.hbase.master.balancer.TestRegionsOnMasterOptions | | | org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite | | | org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk | | | org.apache.hadoop.hbase.TestLocalHBaseCluster | | | org.apache.hadoop.hbase.regionserver.TestMultiColumnScanner | | | org.apache.hadoop.hbase.backup.TestBackupStatusProgress | | | org.apache.hadoop.hbase.regionserver.wal.TestProtobufLog | | | org.apache.hadoop.hbase.regionserver.TestClusterId | | | org.apache.hadoop.hbase.regionserver.TestRegionServerHostname | | | org.apache.hadoop.hbase.backup.TestRestoreBoundaryTests | | | org.apache.hadoop.hbase.fs.TestBlockReorder | | | org.apache.hadoop.hbase.backup.TestBackupBoundaryTests | | | org.apache.hadoop.hbase.regionserver.TestHRegionReplayEvents | | | org.apache.hadoop.hbase.regionserver.TestSeekOptimizations | | | org.apache.hadoop.hbase.replication.TestMultiSlaveReplication | | | org.apache.hadoop.hbase.io.hfile.TestHFileBlock | | | org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover | | | org.apache.hadoop.hbase.util.TestConnectionCache | | | org.apache.hadoop.hbase.backup.TestBackupRepair | | | org.apache.hadoop.hbase.regionserver.TestStore | | | org.apache.hadoop.hbase.wal.TestBoundedRegionGroupingStrategy | | | org.apache.hadoop.hbase.wal.TestWALFactory | | | org.apache.hadoop.hbase.backup.TestIncrementalBackupWithBulkLoad | | | org.apache.hadoop.hbase.backup.TestBackupMultipleDeletes | | | org.apache.hadoop.hbase.regionserver.TestParallelPut | | | org.apache.hadoop.hbase.wal.TestFSHLogProvider | | | org.apache.hadoop.hbase.util.TestIdReadWriteLock | | | org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad | | | org.apache.hadoop.hbase.mapreduce.TestTableSnapshotInputFormat | | | org.apache.hadoop.hbase.replication.regionserver.TestReplicationSourceManagerZkImpl | | | org.apache.hadoop.hbase.replication.TestMasterReplication | | | org.apache.hadoop.hbase.regionserver.TestAtomicOperation | | | org.apache.hadoop.hbase.backup.TestFullBackupSetRestoreSet | | | org.apache.hadoop.hbase.tool.TestCanaryTool | | | org.apache.hadoop.hbase.io.TestFileLink | | | org.apache.hadoop.hbase.regionserver.wal.TestDurability | | | org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat | | | org.apache.hadoop.hbase.io.encoding.TestBufferedDataBlockEncoder | | | org.apache.hadoop.hbase.regionserver.TestMajorCompaction | | | org.apache.hadoop.hbase.regionserver.TestCompactionArchiveIOException | | | org.apache.hadoop.hbase.util.TestFSUtils | | | org.apache.hadoop.hbase.backup.TestBackupShowHistory | | | org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers | | | org.apache.hadoop.hbase.wal.TestWALSplit | | | org.apache.hadoop.hbase.backup.TestIncrementalBackup | | | org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 | | JIRA Issue | HBASE-17442 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12883081/HBASE-17442.master.003.patch | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile xml | | uname | Linux a8c5199de398 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 05f07f6 | | Default Java | 1.8.0_144 | | findbugs | v3.1.0-RC3 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/8223/artifact/patchprocess/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/8223/testReport/ | | modules | C: hbase-client hbase-replication hbase-server . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/8223/console | | Powered by | Apache Yetus 0.4.0 http://yetus.apache.org | This message was automatically generated. > Move most of the replication related classes to hbase-server package > -------------------------------------------------------------------- > > Key: HBASE-17442 > URL: https://issues.apache.org/jira/browse/HBASE-17442 > Project: HBase > Issue Type: Sub-task > Components: build, Replication > Affects Versions: 2.0.0 > Reporter: Guanghao Zhang > Assignee: Guanghao Zhang > Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: 0001-hbase-replication-module.patch, > HBASE-17442.branch-2.001.patch, HBASE-17442.branch-2.001.patch, > HBASE-17442.master.001.patch, HBASE-17442.master.001.patch, > HBASE-17442.master.002.patch, HBASE-17442.master.002.patch, > HBASE-17442.master.002.patch, HBASE-17442.master.002.patch, > HBASE-17442.master.003.patch, HBASE-17442.v1.patch, HBASE-17442.v2.patch, > HBASE-17442.v2.patch, HBASE-17442.v3.patch > > > After the replication requests are routed through master, replication > implementation details didn't need be exposed to client. We should move most > of the replication related classes to hbase-server package. -- This message was sent by Atlassian JIRA (v6.4.14#64029)