[ https://issues.apache.org/jira/browse/HBASE-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137169#comment-16137169 ]
Hadoop QA commented on HBASE-18532: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 21s{color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 2s{color} | {color:blue} The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for instructions. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 57s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 31s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 10s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 42s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 18s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 57s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 57s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 33s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 31m 25s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 39s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 93m 29s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 25s{color} | {color:green} hbase-external-blockcache in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 40s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}147m 52s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed out junit tests | org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure | | | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 | | | org.apache.hadoop.hbase.namespace.TestNamespaceAuditor | | | org.apache.hadoop.hbase.TestHBaseTestingUtility | | | org.apache.hadoop.hbase.mapred.TestTableInputFormat | | | org.apache.hadoop.hbase.TestMultiVersions | | | org.apache.hadoop.hbase.security.access.TestAccessController3 | | | org.apache.hadoop.hbase.client.TestAsyncNonMetaRegionLocator | | | org.apache.hadoop.hbase.security.access.TestAccessController2 | | | org.apache.hadoop.hbase.mapred.TestTableMapReduceUtil | | | org.apache.hadoop.hbase.quotas.TestMasterSpaceQuotaObserver | | | org.apache.hadoop.hbase.master.TestAssignmentListener | | | org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence | | | org.apache.hadoop.hbase.constraint.TestConstraint | | | org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster | | | org.apache.hadoop.hbase.client.TestMultiRespectsLimits | | | org.apache.hadoop.hbase.quotas.TestRegionSizeUse | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService | | | org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster | | | org.apache.hadoop.hbase.master.TestTableStateManager | | | org.apache.hadoop.hbase.master.cleaner.TestReplicationZKNodeCleaner | | | org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures | | | org.apache.hadoop.hbase.master.assignment.TestAssignmentOnRSCrash | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService | | | org.apache.hadoop.hbase.master.TestSplitLogManager | | | org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS | | | org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable | | | org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport | | | org.apache.hadoop.hbase.TestClusterBootOrder | | | org.apache.hadoop.hbase.master.TestRollingRestart | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer | | | org.apache.hadoop.hbase.client.TestScannerTimeout | | | org.apache.hadoop.hbase.quotas.TestSpaceQuotas | | | org.apache.hadoop.hbase.client.TestSplitOrMergeStatus | | | org.apache.hadoop.hbase.master.TestMasterShutdown | | | org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreWithMiniCluster | | | org.apache.hadoop.hbase.security.TestSecureIPC | | | org.apache.hadoop.hbase.client.TestAvoidCellReferencesIntoShippedBlocks | | | org.apache.hadoop.hbase.mapred.TestTableOutputFormatConnectionExhaust | | | org.apache.hadoop.hbase.master.TestMaster | | | org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedureFromClient | | | org.apache.hadoop.hbase.master.procedure.TestTableDescriptorModificationFromClient | | | org.apache.hadoop.hbase.security.access.TestNamespaceCommands | | | org.apache.hadoop.hbase.TestAcidGuarantees | | | org.apache.hadoop.hbase.security.access.TestAccessControlFilter | | | org.apache.hadoop.hbase.TestGlobalMemStoreSize | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL | | | org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes | | | org.apache.hadoop.hbase.quotas.TestSpaceQuotasWithSnapshots | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString | | | org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication | | | org.apache.hadoop.hbase.client.TestClientOperationInterrupt | | | org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache | | | org.apache.hadoop.hbase.security.access.TestCellACLs | | | org.apache.hadoop.hbase.client.TestFastFail | | | org.apache.hadoop.hbase.master.TestRestartCluster | | | org.apache.hadoop.hbase.master.procedure.TestProcedureAdmin | | | org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreRegionReports | | | org.apache.hadoop.hbase.client.TestLeaseRenewal | | | org.apache.hadoop.hbase.client.TestTimestampsFilter | | | org.apache.hadoop.hbase.master.TestWarmupRegion | | | org.apache.hadoop.hbase.master.balancer.TestRegionsOnMasterOptions | | | org.apache.hadoop.hbase.client.TestHCM | | | org.apache.hadoop.hbase.master.procedure.TestMasterProcedureEvents | | | org.apache.hadoop.hbase.security.visibility.TestDefaultScanLabelGeneratorStack | | | org.apache.hadoop.hbase.security.access.TestWithDisabledAuthorization | | | org.apache.hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithSLGStack | | | org.apache.hadoop.hbase.client.TestRawAsyncTableScan | | | org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClient | | | org.apache.hadoop.hbase.quotas.TestSuperUserQuotaPermissions | | | org.apache.hadoop.hbase.security.access.TestTablePermissions | | | org.apache.hadoop.hbase.security.access.TestScanEarlyTermination | | | org.apache.hadoop.hbase.client.TestTableSnapshotScanner | | | org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient | | | org.apache.hadoop.hbase.client.TestSmallReversedScanner | | | org.apache.hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver | | | org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide | | | org.apache.hadoop.hbase.client.TestCloneSnapshotFromClientWithRegionReplicas | | | org.apache.hadoop.hbase.master.TestRegionPlacement2 | | | org.apache.hadoop.hbase.client.TestResultScannerCursor | | | org.apache.hadoop.hbase.quotas.TestQuotaAdmin | | | org.apache.hadoop.hbase.client.TestIncrementsFromClientSide | | | org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedure | | | org.apache.hadoop.hbase.master.procedure.TestModifyColumnFamilyProcedure | | | org.apache.hadoop.hbase.client.TestAsyncAdminBuilder | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsOnNewVersionBehaviorTable | | | org.apache.hadoop.hbase.TestPartialResultsFromClientSide | | | org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas | | | org.apache.hadoop.hbase.master.procedure.TestCreateNamespaceProcedure | | | org.apache.hadoop.hbase.master.procedure.TestAddColumnFamilyProcedure | | | org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure | | | org.apache.hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure | | | org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat | | | org.apache.hadoop.hbase.master.TestMetaShutdownHandler | | | org.apache.hadoop.hbase.master.procedure.TestTruncateTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestCloneSnapshotProcedure | | | org.apache.hadoop.hbase.client.TestMobSnapshotCloneIndependence | | | org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 | | JIRA Issue | HBASE-18532 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12883130/HBASE-18532-V2.0.PATCH | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 303d9c3f9479 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 05f07f6 | | Default Java | 1.8.0_144 | | findbugs | v3.1.0-RC3 | | whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/8232/artifact/patchprocess/whitespace-eol.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/8232/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/8232/testReport/ | | modules | C: hbase-server hbase-external-blockcache U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/8232/console | | Powered by | Apache Yetus 0.4.0 http://yetus.apache.org | This message was automatically generated. > Improve cache related stats rendered on RS UI > --------------------------------------------- > > Key: HBASE-18532 > URL: https://issues.apache.org/jira/browse/HBASE-18532 > Project: HBase > Issue Type: Improvement > Components: regionserver, UI > Affects Versions: 1.1.2 > Reporter: Biju Nair > Assignee: Biju Nair > Attachments: COMBINED-STATS.PNG, HBASE-18532-1.1.2.PATCH, > HBASE-18532.PATCH, HBASE-18532-V1.0.PATCH, HBASE-18532-V2.0.PATCH, > L1-STATS.PNG, L2-STATS.PNG > > > The stats currently rendered for L1 and L2 cache are incorrect. Refer to the > attached screenshots of stats from a cluster showing the combined cache > stats, L1 stats and L2 stats. For e.g. the combined stats shows 38 GB used > for cache while if we sum size of L1 and L2 cache the value is way less. One > way we can improve this is to use the same stats used to populate the > combined stats to render the values of L1 & L2 cache. Also for usability we > can remove the table with details with BucketCache buckets from the L2 cache > stats since this is going to be long for any installation using L2 cache. > This will help in understanding the cache usage better. Thoughts? If there > are no concerns will submit a patch. -- This message was sent by Atlassian JIRA (v6.4.14#64029)