[
https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139372#comment-16139372
]
Hudson commented on HBASE-18509:
--------------------------------
FAILURE: Integrated in Jenkins build HBASE-14070.HLC #270 (See
[https://builds.apache.org/job/HBASE-14070.HLC/270/])
HBASE-18509 (ADDENDUM) Fix NPEs when mocking RS clocks in tests (appy: rev
bc48d841bce1dbcc31016ff55837b9f1b242e3d6)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Clocks.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWALLockup.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestWALReplay.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionSplitPolicy.java
> [HLC] Finishing cleanups
> ------------------------
>
> Key: HBASE-18509
> URL: https://issues.apache.org/jira/browse/HBASE-18509
> Project: HBase
> Issue Type: Sub-task
> Reporter: Appy
> Assignee: Amit Patel
> Attachments: HBASE-18509.HBASE-14070.HLC.001.patch,
> HBASE-18509.HBASE-14070.HLC.002.patch, HBASE-18509.HBASE-14070.HLC.003.patch,
> HBASE-18509.HBASE-14070.HLC.004.patch, HBASE-18509.HBASE-14070.HLC.005.patch
>
>
> Track all types of cleanups here:
> - (done in 001.patch) --Rename classes to more consistent naming:
> SystemClock, SystemMonotonicClock, HybridLogicalClock--
> - (done in 001.patch) --Move implementations out from Clock interface. It's a
> simple interface of 6 fns but very overloaded right now with everything put
> inside it.--
> - (done in 004.patch) --Maybe encapsulate all clocks in RS/Master into a new
> class. Then RSServices can just have getClocks() function.--
> {noformat}
> class Clocks {
> // all 3 types of clocks.
> // Fns:
> - update(ClockType, timestamp)
> - updateAll(List\<NodeTime>)
> - int64 now(ClockType)
> - List\<NodeTime> nowAll()
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
