[ https://issues.apache.org/jira/browse/HBASE-15982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140538#comment-16140538 ]
Hudson commented on HBASE-15982: -------------------------------- FAILURE: Integrated in Jenkins build HBase-2.0 #389 (See [https://builds.apache.org/job/HBase-2.0/389/]) HBASE-15982 Interface ReplicationEndpoint extends Guava's Service (stack: rev ec7bca1769dcd825289e485c331e716df8ee33a1) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationEndpoint.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationEndpoint.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/BaseReplicationEndpoint.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/replication/TestReplicationAdminWithClusters.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java > Interface ReplicationEndpoint extends Guava's Service > ----------------------------------------------------- > > Key: HBASE-15982 > URL: https://issues.apache.org/jira/browse/HBASE-15982 > Project: HBase > Issue Type: Bug > Reporter: Andrew Purtell > Assignee: stack > Priority: Blocker > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-15982.master.001.patch, > HBASE-15982.master.002.patch, HBASE-15982.master.003.patch, > HBASE-15982.master.004.patch > > > We have Guava's Service leaking into the LimitedPrivate interface > ReplicationEndpoint: > {code} > public interface ReplicationEndpoint extends Service, > ReplicationPeerConfigListener > {code} > This required a private patch when I updated Guava for our internal > deployments. This is going to be a problem for us for long term maintenance > and implenters of pluggable replication endpoints. LP is only less than > public by a degree. We shouldn't leak types from third part code into either > Public or LP APIs in my opinion. Let's fix. -- This message was sent by Atlassian JIRA (v6.4.14#64029)