[ 
https://issues.apache.org/jira/browse/HBASE-17249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142273#comment-16142273
 ] 

Hudson commented on HBASE-17249:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-2.0 #396 (See 
[https://builds.apache.org/job/HBase-2.0/396/])
Revert "HBASE-17249 Get/Scan's setTimeRange/setColumnFamilyTimeRange can 
(huaxiangsun: rev f74cf679ecebed2ab5c95ccd678f48482644b829)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Query.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java


> Get/Scan's setTimeRange/setColumnFamilyTimeRange can take the TimeRange 
> reference as the parameter instead of creating a new setColumnFamilyTimeRange 
> instance
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-17249
>                 URL: https://issues.apache.org/jira/browse/HBASE-17249
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: huaxiang sun
>            Assignee: huaxiang sun
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17249-master-001.patch, 
> HBASE-17249.master.001.patch, HBASE-17249-master-002.patch, 
> HBASE-17249-master-003.patch
>
>
> Going through the code, found For Get/Scan's 
> setTimeRange/setColumnFamilyTimeRange, it can use  TimeRange as reference 
> instead of creating a new one.
> Reference:
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L500
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L506
> We can implement this in a similar way as filter:
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L510
> I checked it is same with branch-1.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to