[ https://issues.apache.org/jira/browse/HBASE-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142674#comment-16142674 ]
ChunHao commented on HBASE-18611: --------------------------------- ??+ CellProtos.Cell cell = org.apache.hadoop.hbase.protobuf.ProtobufUtil.toCell(offheapKV); + Cell newOffheapKV = org.apache.hadoop.hbase.protobuf.ProtobufUtil.toCell(cell); After fixing the wrong import, you don't need to use the fully qualified name for ProtobufUtil.?? [~chia7712], I have removed the "org.apache.hadoop.hbase.protobuf" for ProtobufUtil in v2 patch. > Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil > ------------------------------------------------------------------------------ > > Key: HBASE-18611 > URL: https://issues.apache.org/jira/browse/HBASE-18611 > Project: HBase > Issue Type: Task > Components: Protobufs, test > Affects Versions: 3.0.0, 2.0.0-alpha-1 > Reporter: Chia-Ping Tsai > Assignee: ChunHao > Priority: Minor > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-18611.master.v0.patch, > HBASE-18611.master.v1.patch, HBASE-18611.master.v2.patch > > > We copied all codes from o.a.h.h.p.ProtobufUtil to o.a.h.h.s.p.ProtobufUtil, > but we ignored the test codes. Let us increase the code coverage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)