[ 
https://issues.apache.org/jira/browse/HBASE-18691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143147#comment-16143147
 ] 

Hudson commented on HBASE-18691:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-2.0 #406 (See 
[https://builds.apache.org/job/HBase-2.0/406/])
HBASE-18691 [compat 1-2] HCD remove and removeConfiguration change (chia7712: 
rev 13769ab7c15f2d72224026336fa35cea0ac18cc0)
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java


> [compat 1-2] HCD remove and removeConfiguration change return type
> ------------------------------------------------------------------
>
>                 Key: HBASE-18691
>                 URL: https://issues.apache.org/jira/browse/HBASE-18691
>             Project: HBase
>          Issue Type: Sub-task
>          Components: API
>            Reporter: stack
>            Assignee: Chia-Ping Tsai
>             Fix For: 2.0.0-alpha-3
>
>         Attachments: HBASE-18691.v0.patch
>
>
> Change made in HBASE-18008. Asking [~chia7712] if ok to undo.
> Here is complaint from JACC:
> {code}
> hbase-client-1.2.6.jar, HColumnDescriptor.class
> package org.apache.hadoop.hbase
> [−] HColumnDescriptor.remove ( byte[ ] key )  :  void  1  
> org/apache/hadoop/hbase/HColumnDescriptor.remove:([B)V
> Change        Effect
> 1     Return value type has been changed from void to HColumnDescriptor.      
> This method has been removed because the return type is part of the method 
> signature.
> [−] HColumnDescriptor.removeConfiguration ( String key )  :  void  1  
> org/apache/hadoop/hbase/HColumnDescriptor.removeConfiguration:(Ljava/lang/String;)V
> Change        Effect
> 1     Return value type has been changed from void to HColumnDescriptor.      
> This method has been removed because the return type is part of the method 
> signature.
> {code}
> Binary breaking but not src breaking. See 
> https://stackoverflow.com/questions/3589946/retrofitting-void-methods-to-return-its-argument-to-facilitate-fluency-breaking
>  for good discussion. Probably not a prob. but just in case and if not really 
> needed, will purge.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to