[ 
https://issues.apache.org/jira/browse/HBASE-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185767#comment-13185767
 ] 

jirapos...@reviews.apache.org commented on HBASE-5196:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3488/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

When the master starts up, this patch tries to scan all offline split parents 
and fix up missing daughters as the ServerShutdownHandler does.


This addresses bug HBASE-5196.
    https://issues.apache.org/jira/browse/HBASE-5196


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/master/HMaster.java cb2f084 
  
src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 
8f4f4b8 
  src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java 41f5dff 

Diff: https://reviews.apache.org/r/3488/diff


Testing
-------

I test the fix in my real cluster and it does fix the problem.

I am working on a unit test now.


Thanks,

Jimmy


                
> Failure in region split after PONR could cause region hole
> ----------------------------------------------------------
>
>                 Key: HBASE-5196
>                 URL: https://issues.apache.org/jira/browse/HBASE-5196
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.92.0, 0.94.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>
> If region split fails after PONR, it relies on the master ServerShutdown 
> handler to fix it.  However, if the master doesn't get a chance to fix it.  
> There will be a hole in the region chain.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to