[ 
https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185778#comment-13185778
 ] 

Lars Hofhansl commented on HBASE-3584:
--------------------------------------

It's kind of how it works now. If walEdit is passed in non-null, use that one 
(and also assume that the caller used that same walEdit to execute the 
pre-hooks and will use it execute the post hooks), otherwise make a local one.

If there is a non-null passedWalEdit, that same one *has* to be used for 
addFamilyMapToWALEdit() and log.append().

In the end it is similar to passing the writeEntry in. The caller perform the 
grouping of the operations, so it has to control what writeEntry and what 
walEdits to use.

Would it be less confusing to pass in an extra flag to indicate whether the 
coprocessor hooks need to be executed?
                
> We need to atomically put/delete/increment in one call
> ------------------------------------------------------
>
>                 Key: HBASE-3584
>                 URL: https://issues.apache.org/jira/browse/HBASE-3584
>             Project: HBase
>          Issue Type: Bug
>          Components: client, coprocessors, regionserver
>            Reporter: ryan rawson
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.0
>
>         Attachments: 3584-v1.txt, 3584-v3.txt
>
>
> Right now we have the following calls:
> put(Put)
> delete(Delete)
> increment(Increments)
> But we cannot combine all of the above in a single call, complete with a 
> single row lock.  It would be nice to do that.
> It would also allow us to do a CAS where we could do a put/increment if the 
> check succeeded.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to