[ 
https://issues.apache.org/jira/browse/HBASE-18765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai updated HBASE-18765:
-----------------------------------
    Description: 
{code}
      //We balance per group instead of per table
      List<RegionPlan> plans = new ArrayList<>();
      for(Map.Entry<TableName, Map<ServerName, List<HRegionInfo>>> tableMap:
          getRSGroupAssignmentsByTable(groupName).entrySet()) {
        LOG.info("Creating partial plan for table " + tableMap.getKey() + ": "
            + tableMap.getValue());
        List<RegionPlan> partialPlans = 
balancer.balanceCluster(tableMap.getValue());
        LOG.info("Partial plan for table " + tableMap.getKey() + ": " + 
partialPlans);
        if (partialPlans != null) {
          plans.addAll(partialPlans);
        }
      }
      long startTime = System.currentTimeMillis();
      balancerRan = plans != null;
{code}
The *plans* is never null.

  was:
{code}
      //We balance per group instead of per table
      List<RegionPlan> plans = new ArrayList<>();
      for(Map.Entry<TableName, Map<ServerName, List<HRegionInfo>>> tableMap:
          getRSGroupAssignmentsByTable(groupName).entrySet()) {
        LOG.info("Creating partial plan for table " + tableMap.getKey() + ": "
            + tableMap.getValue());
        List<RegionPlan> partialPlans = 
balancer.balanceCluster(tableMap.getValue());
        LOG.info("Partial plan for table " + tableMap.getKey() + ": " + 
partialPlans);
        if (partialPlans != null) {
          plans.addAll(partialPlans);
        }
      }
      long startTime = System.currentTimeMillis();
      balancerRan = plans != null;
{code}
The *plans* never be null.


> The value of balancerRan is true even though no plans are executed
> ------------------------------------------------------------------
>
>                 Key: HBASE-18765
>                 URL: https://issues.apache.org/jira/browse/HBASE-18765
>             Project: HBase
>          Issue Type: Bug
>          Components: rsgroup
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Minor
>             Fix For: 2.0.0-alpha-3
>
>         Attachments: HBASE-18765.v0.patch
>
>
> {code}
>       //We balance per group instead of per table
>       List<RegionPlan> plans = new ArrayList<>();
>       for(Map.Entry<TableName, Map<ServerName, List<HRegionInfo>>> tableMap:
>           getRSGroupAssignmentsByTable(groupName).entrySet()) {
>         LOG.info("Creating partial plan for table " + tableMap.getKey() + ": "
>             + tableMap.getValue());
>         List<RegionPlan> partialPlans = 
> balancer.balanceCluster(tableMap.getValue());
>         LOG.info("Partial plan for table " + tableMap.getKey() + ": " + 
> partialPlans);
>         if (partialPlans != null) {
>           plans.addAll(partialPlans);
>         }
>       }
>       long startTime = System.currentTimeMillis();
>       balancerRan = plans != null;
> {code}
> The *plans* is never null.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to