[
https://issues.apache.org/jira/browse/HBASE-18727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159466#comment-16159466
]
Sudeep Sunthankar commented on HBASE-18727:
-------------------------------------------
Hi [~enis],
The changes look good. Couple of points:-
# test-util directory consists code related to standalone and mini cluster.
Instead of excluding the sources in EXCLUDE_SRC we can remove the test-util
folder from the MODULES variable itself as follows:
{code}
MODULES := connection core exceptions security serde utils
{code}
# Also I have noticed that we have a unit-test by the name of
connection/rpc-test-server-handler.cc. We should either change the below
variable as follows to exclude it from the library or rename the file.
{code}
EXCLUDE_SRC := $(foreach sdir,$(SRC_DIR),$(wildcard $(sdir)/*-test*.cc))
{code}
Thanks.
> [C++] Don't link JNI/JVM stuff into libHbaseClient
> --------------------------------------------------
>
> Key: HBASE-18727
> URL: https://issues.apache.org/jira/browse/HBASE-18727
> Project: HBase
> Issue Type: Sub-task
> Reporter: Scott Hunt
> Priority: Minor
> Fix For: HBASE-14850
>
> Attachments: hbase-18727-v2.patch, Makefile_HBASE_18727.patch
>
>
> It doesn't seem like we should be linking the objects from the test-util
> directory into the library, as those [I believe] are just for testing.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
