[ 
https://issues.apache.org/jira/browse/HBASE-18649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159685#comment-16159685
 ] 

stack commented on HBASE-18649:
-------------------------------

[~ram_krish] You thinking we commit this to 3.0. What we do for 2.0? Can we do 
any deprecations?

Is it correct putting this in method....

ExtendedCellWrapper.class

How come we do KVSortReducer in below?

604         } else if 
(ExtendedCellWrapper.class.equals(job.getMapOutputValueClass())) {
605           job.setReducerClass(KeyValueSortReducer.class);

Should it be a CellSortReducer?

This stuff internal or external?     
job.setOutputValueClass(ExtendedCellWrapper.class);

Can we change this... KeyValueWritableComparable to be CellWC?

We have to do this stuff?

        530             } else {
531               kv = new KeyValue(kv.getRowArray(), // row buffer
532                 kv.getRowOffset(),        // row offset
533                 kv.getRowLength(),        // row length
534                 newCfName,                // CF buffer
535                 0,                        // CF offset
536                 newCfName.length,         // CF length
537                 kv.getQualifierArray(),   // qualifier buffer
538                 kv.getQualifierOffset(),  // qualifier offset
539                 kv.getQualifierLength(),  // qualifier length
540                 kv.getTimestamp(),        // timestamp
541                 KeyValue.Type.codeToType(kv.getTypeByte()), // KV Type
542                 kv.getValueArray(),       // value buffer
543                 kv.getValueOffset(),      // value offset
544                 kv.getValueLength(),      // value length
545                 kv.getTagsArray(),        // tag buffer
546                 kv.getTagsOffset(),       // tag offset
547                 kv.getTagsLength());      // tag length
548             }

ExtendedCellWrapper the right name? MapReduceCell?

> Deprecate KV Usage in MR to move to Cells in 3.0
> ------------------------------------------------
>
>                 Key: HBASE-18649
>                 URL: https://issues.apache.org/jira/browse/HBASE-18649
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>    Affects Versions: 2.0.0-alpha-2
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0, 3.0.0, 2.1.0
>
>         Attachments: HBASE-18649_master_2.patch, HBASE-18649_master.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to