[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160770#comment-16160770 ]
Anoop Sam John commented on HBASE-10944: ---------------------------------------- I read RowIndexCodecV1 and it is doing this in #decodeKeyValues. First of all this method is not used in real code execution path. Just tests use this. (We should mark/comment same in the Codec#Decoder itself). Also there we do {code} KeyValue currentCell = KeyValueUtil.copyToNewKeyValue(cell); out.write(currentCell.getBuffer(), currentCell.getOffset(), currentCell.getLength()); {code} So the cell data is been copied and made into a KV and on that calling getBuffer. This is perfectly ok. That is what we were discussing that on the KV the getBuffer() make sense and this should not be a deprecated method. We dont have such methods in Cells. So things are fine as we are working with Cells in the actual read/write flows. We can remove this deprecation with fat comments in code as part of some of the sub task jiras here. bq.Am fine with expsosing it for Cells. Add a clear comment saying avoid using in the actual code. Got confused as u refer Cell. So in Cells there wont be such methods.. This is abt exposing it in KV where we know, we have a single buffer backing the entire cell data. I believe u mean that only. > Remove all kv.getBuffer() and kv.getRow() references existing in the code > ------------------------------------------------------------------------- > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Priority: Critical > Fix For: 1.5.0, 2.0.0-alpha-3 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)