[
https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171080#comment-16171080
]
Vincent Poon commented on HBASE-18829:
--------------------------------------
The lock is a non-fair mode lock, so in theory there are no guarantees as to
when the writelock will be obtained when there are many readers contending for
the lock as well. Setting this.closing(true) at least prevents other readers
from trying to obtain the read lock, giving the writer eventual access to the
lock. At least, that's my understanding of the intention from looking at the
code.
> Consider reverting HBASE-14893 Race between mutation on region and region
> closing operation
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-18829
> URL: https://issues.apache.org/jira/browse/HBASE-18829
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 18829.v1.txt, HBASE-18829.patch
>
>
> HBASE-14893 was brought to attention by [~rajeshbabu] over PHOENIX-3111.
> This issue is to consider reverting the fix from HBASE-14893 based on the
> following observations:
> * The closing boolean was intended to be acquired before taking the lock
> ([~enis])
> * Phoenix local index has evolved over the years, the situation leading to
> NotServingRegionException may not exist from Phoenix side
> * Even if the situation still exists, downstream project (Phoenix) should
> properly handle NotServingRegionException without change in locking scheme in
> hbase
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
