[ https://issues.apache.org/jira/browse/HBASE-17399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175228#comment-16175228 ]
ChunHao commented on HBASE-17399: --------------------------------- [~stack] An original example for a generated file is: /tmp/larsgeorgeslave-3.internal.larsgeorge.com\:16020 The result in a rather strange \:. Therefore, I deleted the '\'. Besides, To make the result easy to handle, I added a divider '#' between the username and the hostname, and I also added a divider '#' between the hostname and the port. Thus, the original example becomes "/tmp/larsgeorge#slave-3.internal.larsgeorge.com#16020" Finally, I corrected the command line help message: the original help message was "default /tmp/<hostname:port>", now the help message is "default /tmp/<username#hostname#port>". > region_mover.rb uses different default filename, also needs slight change > ------------------------------------------------------------------------- > > Key: HBASE-17399 > URL: https://issues.apache.org/jira/browse/HBASE-17399 > Project: HBase > Issue Type: Bug > Affects Versions: 1.3.0 > Reporter: Lars George > Assignee: ChunHao > Labels: beginner > Attachments: HBASE-17399.branch-1.3.v0.patch, > HBASE-17399.branch-1.3.v1.patch > > > The command line help prints: > {noformat} > -f, --filename=FILE File to save regions list into unloading, \ > or read from loading; default /tmp/<hostname:port> > {noformat} > while in reality, the code does this: > {code} > def getFilename(options, targetServer, port) > filename = options[:file] > if not filename > filename = "/tmp/" + ENV['USER'] + targetServer + ":" + port > end > return filename > end > {code} > An example for a generated file is: > {noformat} > /tmp/larsgeorgeslave-3.internal.larsgeorge.com\:16020 > {noformat} > I suggest we fix the command line help explanation. But first, we should also > fix how the name is generated, *adding* a divider between the user name and > the host name, and also change how the port is attached to the host name. > Currently this results in a rather strange {{\:}} which could be hard to > handle. Maybe we simply use an exclamation mark or hash for both? For example: > {noformat} > /tmp/larsgeorge!slave-3.internal.larsgeorge.com!16020 > /tmp/larsgeorge#slave-3.internal.larsgeorge.com#16020 > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)