[
https://issues.apache.org/jira/browse/HBASE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187448#comment-13187448
]
Zhihong Yu commented on HBASE-5179:
-----------------------------------
{code}
+ int waitTime = conf.getInt("hbase.master.assignMeta.timeout",
+ 60000);
+ for (int i = 0; metaServerInfo != null; i++) {
+ if
(!this.fileSystemManager.existLogs(metaServerInfo.getServerName())) {
{code}
I think "hbase.master.meta.assignment.timeout" would be more appropriate.
metaServerInfo.getServerName() can be stored in a variable before entering the
for loop (minor).
{code}
+ if (i >= waitTime / 1000) {
+ throw new RuntimeException(
+ "Wait META server to finish splitting log for a time out");
+ }
+ sleep(1000);
{code}
I think the time accounting above is inaccurate because we don't know how long
the sleep() call has taken.
Also, "Timed out waiting for .META. server to finish splitting log" would be
better exception message.
> Concurrent processing of processFaileOver and ServerShutdownHandler may cause
> region to be assigned before log splitting is completed, causing data loss
> --------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5179
> URL: https://issues.apache.org/jira/browse/HBASE-5179
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.2
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 5179-90.txt, 5179-90v2.patch, 5179-90v3.patch,
> 5179-90v4.patch, 5179-90v5.patch, 5179-90v6.patch, 5179-90v7.patch,
> 5179-90v8.patch, 5179-v2.txt, 5179-v3.txt, 5179-v4.txt, hbase-5179.patch,
> hbase-5179v5.patch, hbase-5179v6.patch, hbase-5179v7.patch, hbase-5179v8.patch
>
>
> If master's processing its failover and ServerShutdownHandler's processing
> happen concurrently, it may appear following case.
> 1.master completed splitLogAfterStartup()
> 2.RegionserverA restarts, and ServerShutdownHandler is processing.
> 3.master starts to rebuildUserRegions, and RegionserverA is considered as
> dead server.
> 4.master starts to assign regions of RegionserverA because it is a dead
> server by step3.
> However, when doing step4(assigning region), ServerShutdownHandler may be
> doing split log, Therefore, it may cause data loss.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
