[
https://issues.apache.org/jira/browse/HBASE-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195497#comment-16195497
]
Hadoop QA commented on HBASE-12260:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
41s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 41 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
45s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
25s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
10s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
40m 29s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 48s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
18s{color} | {color:red} hbase-server generated 6 new + 0 unchanged - 0 fixed =
6 total (was 0) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
44s{color} | {color:red} hbase-rsgroup generated 4 new + 0 unchanged - 0 fixed
= 4 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
30s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
45s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 49m 11s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
24s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 4m 9s{color}
| {color:red} hbase-backup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
42s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}136m 57s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
| | instanceof will always return true for all non-null values in
org.apache.hadoop.hbase.master.ServerManager.getRsAdmin(ServerName), since all
org.apache.hadoop.hbase.master.HMaster are instances of
org.apache.hadoop.hbase.regionserver.HRegionServer At ServerManager.java:for
all non-null values in
org.apache.hadoop.hbase.master.ServerManager.getRsAdmin(ServerName), since all
org.apache.hadoop.hbase.master.HMaster are instances of
org.apache.hadoop.hbase.regionserver.HRegionServer At ServerManager.java:[line
773] |
| | instanceof will always return true for all non-null values in
org.apache.hadoop.hbase.master.procedure.MasterProcedureEnv.waitServerCrashProcessingEnabled(Procedure),
since all org.apache.hadoop.hbase.master.HMaster are instances of
org.apache.hadoop.hbase.master.HMaster At MasterProcedureEnv.java:for all
non-null values in
org.apache.hadoop.hbase.master.procedure.MasterProcedureEnv.waitServerCrashProcessingEnabled(Procedure),
since all org.apache.hadoop.hbase.master.HMaster are instances of
org.apache.hadoop.hbase.master.HMaster At MasterProcedureEnv.java:[line 154] |
| | Self assignment of field SplitLogWorker.server in new
org.apache.hadoop.hbase.regionserver.SplitLogWorker(HRegionServer,
Configuration, SplitLogWorker$TaskExecutor) At SplitLogWorker.java:in new
org.apache.hadoop.hbase.regionserver.SplitLogWorker(HRegionServer,
Configuration, SplitLogWorker$TaskExecutor) At SplitLogWorker.java:[line 74] |
| | Self assignment of field SplitLogWorker.server in new
org.apache.hadoop.hbase.regionserver.SplitLogWorker(HRegionServer,
Configuration, SplitLogWorker$TaskExecutor) At SplitLogWorker.java:in new
org.apache.hadoop.hbase.regionserver.SplitLogWorker(HRegionServer,
Configuration, SplitLogWorker$TaskExecutor) At SplitLogWorker.java:[line 78] |
| | Self assignment of field RegionServerSnapshotManager.hrs in new
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager(Configuration,
HRegionServer, ProcedureMemberRpcs, ProcedureMember) At
RegionServerSnapshotManager.java:in new
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager(Configuration,
HRegionServer, ProcedureMemberRpcs, ProcedureMember) At
RegionServerSnapshotManager.java:[line 112] |
| | Uninitialized read of hrs in new
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager(Configuration,
HRegionServer, ProcedureMemberRpcs, ProcedureMember) At
RegionServerSnapshotManager.java:new
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager(Configuration,
HRegionServer, ProcedureMemberRpcs, ProcedureMember) At
RegionServerSnapshotManager.java:[line 112] |
| FindBugs | module:hbase-rsgroup |
| | Dead store to misplacedRegions in
org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.correctAssignments(Map)
At
RSGroupBasedLoadBalancer.java:org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.correctAssignments(Map)
At RSGroupBasedLoadBalancer.java:[line 330] |
| | Private method
org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl.flushConfig() is never
called At RSGroupInfoManagerImpl.java:called At
RSGroupInfoManagerImpl.java:[lines 433-434] |
| | Useless object stored in variable assignedRegions of method
org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.waitForGroupTableOnline()
At RSGroupInfoManagerImpl.java:assignedRegions of method
org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.waitForGroupTableOnline()
At RSGroupInfoManagerImpl.java:[line 641] |
| | Useless object stored in variable foundRegions of method
org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.waitForGroupTableOnline()
At RSGroupInfoManagerImpl.java:foundRegions of method
org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.waitForGroupTableOnline()
At RSGroupInfoManagerImpl.java:[line 640] |
| Failed junit tests | hadoop.hbase.master.locking.TestLockManager |
| | hadoop.hbase.master.locking.TestLockProcedure |
| | hadoop.hbase.master.normalizer.TestSimpleRegionNormalizer |
| | hadoop.hbase.master.balancer.TestRegionLocationFinder |
| | hadoop.hbase.ipc.TestNettyRpcServer |
| | hadoop.hbase.regionserver.TestHRegionFileSystem |
| | hadoop.hbase.client.TestClientClusterStatus |
| | hadoop.hbase.master.TestClockSkewDetection |
| | hadoop.hbase.procedure.TestProcedureManager |
| | hadoop.hbase.backup.TestBackupHFileCleaner |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-12260 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12890832/HBASE-12260.master.004.patch
|
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc |
| uname | Linux 8af79f183c82 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / e2ad4c0 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/8982/artifact/patchprocess/new-findbugs-hbase-server.html
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/8982/artifact/patchprocess/new-findbugs-hbase-rsgroup.html
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8982/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8982/artifact/patchprocess/patch-unit-hbase-backup.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8982/testReport/ |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-rsgroup
hbase-backup U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8982/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> MasterServices needs a short-back-and-sides; pare-back exposure of internals
> and IA.Private classes
> ---------------------------------------------------------------------------------------------------
>
> Key: HBASE-12260
> URL: https://issues.apache.org/jira/browse/HBASE-12260
> Project: HBase
> Issue Type: Sub-task
> Components: master
> Reporter: ryan rawson
> Assignee: stack
> Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-12260.master.001.patch,
> HBASE-12260.master.002.patch, HBASE-12260.master.003.patch,
> HBASE-12260.master.004.patch, HBASE-12260.master.005.patch
>
>
> A major issue with MasterServices is the MasterCoprocessorEnvironment exposes
> this class even though MasterServices is tagged with
> @InterfaceAudience.Private
> This means that the entire internals of the HMaster is essentially part of
> the coprocessor API. Many of the classes returned by the MasterServices API
> are highly internal, extremely powerful, and subject to constant change.
> Perhaps a new API to replace MasterServices that is use-case focused, and
> justified based on real world co-processors would suit things better.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
