[ 
https://issues.apache.org/jira/browse/HBASE-19021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207029#comment-16207029
 ] 

stack commented on HBASE-19021:
-------------------------------

Thanks for taking a look [~jerryhe]

bq. hbase.master.loadbalance.bytable is not respected. It is always 'bytable'. 
Previous default is cluster wide, not by table.

Thanks. bytable is not implemented in AMv2 IIRC.

bq.  Servers with no assignments is not added for balance consideration.

You saying when you add a Server, it doesn't get Regions? (I don't recall this 
in testing but perhaps so).

bq. Crashed server is not removed from the in-memory server map in 
RegionStates, which affects balance.

Ok. Good.

bq. Draining marker is not respected when balance.

You are fixing this over in another issue?

Thanks.

I skimmed the patch. It looks great. Thanks.



> Restore a few important missing logics for balancer in 2.0
> ----------------------------------------------------------
>
>                 Key: HBASE-19021
>                 URL: https://issues.apache.org/jira/browse/HBASE-19021
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jerry He
>            Assignee: Jerry He
>            Priority: Critical
>         Attachments: HBASE-19021-master.patch
>
>
> After looking at the code, and some testing, I see the following things are 
> missing for balancer to work properly after AMv2.
> # hbase.master.loadbalance.bytable is not respected. It is always 'bytable'. 
> Previous default is cluster wide, not by table.
> # Servers with no assignments is not added for balance consideration.
> # Crashed server is not removed from the in-memory server map in 
> RegionStates, which affects balance.
> # Draining marker is not respected when balance.
> Also try to re-enable {{TestRegionRebalancing}}, which has a 
> {{testRebalanceOnRegionServerNumberChange}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to