[ 
https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223966#comment-16223966
 ] 

Duo Zhang commented on HBASE-19095:
-----------------------------------

{quote}
Which other StoreScanner constructor we should be using then when we do want to 
drop cells?
{quote}

This is not the point I'd say. We do have in memory compaction mechanism other 
than 'basic' which we want to drop cells so we need to provide the CP hooks. 
The fix version is moved to beta1 so it will not block the alpha4 release. 
Let's fix this before beta1 release.

And for not droppring cells, HBASE-19033 provides a CustomizedScanInfoBuilder 
which can reset the max versions when open a StoreScanner. I tried to reset it 
to Integer.MAX_VALUE and then I got several failed UTs for in memory 
compaction. Maybe I modified the wrong place since I'm not very familiar with 
in memory compaction.

Thanks.

> Add CP hooks in RegionObserver for in memory compaction
> -------------------------------------------------------
>
>                 Key: HBASE-19095
>                 URL: https://issues.apache.org/jira/browse/HBASE-19095
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: Duo Zhang
>             Fix For: 2.0.0-beta-1
>
>
> This is a hole in our CP hooks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to