[ https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225385#comment-16225385 ]
Chia-Ping Tsai commented on HBASE-19024: ---------------------------------------- {code} + public static final String WAL_HSYNC_CONF_KEY = "hbase.wal.hsync"; + + public static final boolean DEFAULT_WAL_HSYNC = false; + {code} Putting them in HRegion is more suitable as the {{HConstants}} is an anti-pattern. > provide a configurable option to hsync WAL edits to the disk for better > durability > ---------------------------------------------------------------------------------- > > Key: HBASE-19024 > URL: https://issues.apache.org/jira/browse/HBASE-19024 > Project: HBase > Issue Type: Improvement > Components: wal > Environment: > Reporter: Vikas Vishwakarma > Assignee: Harshal Jain > Attachments: branch-1.branch-1.patch, master.patch, master.v2.patch, > master.v3.patch > > > At present we do not have an option to hsync WAL edits to the disk for better > durability. In our local tests we see 10-15% latency impact of using hsync > instead of hflush which is not very high. > We should have a configurable option to hysnc WAL edits instead of just > sync/hflush which will call the corresponding API on the hadoop side. > Currently HBase handles both SYNC_WAL and FSYNC_WAL as the same calling > FSDataOutputStream sync/hflush on the hadoop side. This can be modified to > let FSYNC_WAL call hsync on the hadoop side instead of sync/hflush. We can > keep the default value to sync as the current behavior and hsync can be > enabled based on explicit configuration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)