[ https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226269#comment-16226269 ]
stack commented on HBASE-19092: ------------------------------- bq. Which means for CPs we don't give them a chance to build a tag. We have to. Timeline Server needs it. bq. I think making ECB LimitedPrivate is not right IMHO. What do you think? I think we are too late for alpha-4. There is too much to do in here still. We should just punt this to beta-1. Also Tags by nature (server-side-only) requires ECB access I'd say. ECB is an Interface. Making it LP seems fine. And you have a factory. Can't you just add getCellBuilder(type) to RegionCoprocessorEnvironment? It'd return a CellBuilder that the CP could use. It would be all LP Interfaces? Then no need of the LP*Util stuff? Can I have Tag builder, something that will make simple Tag [] to give to the CellBuilder? There is none in the patch. Can we have a smaller patch? What you reckon? Thanks [~ram_krish]. > Make Tag IA.LimitedPrivate and expose for CPs > --------------------------------------------- > > Key: HBASE-19092 > URL: https://issues.apache.org/jira/browse/HBASE-19092 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19092-branch-2.patch, > HBASE-19092_001-branch-2.patch > > > We need to make tags as LimitedPrivate as some use cases are trying to use > tags like timeline server. The same topic was discussed in dev@ and also in > HBASE-18995. > Shall we target this for beta1 - cc [~saint....@gmail.com]. > So once we do this all related Util methods and APIs should also move to > LimitedPrivate Util classes. -- This message was sent by Atlassian JIRA (v6.4.14#64029)