[
https://issues.apache.org/jira/browse/HBASE-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190441#comment-13190441
]
Zhihong Yu commented on HBASE-5243:
-----------------------------------
{code}
+ while(!this.isInterrupted() || !closeLogSyncer) {
{code}
Since closeLogSyncer is set to false initially, when the interrupt flag is
raised, the loop would continue.
I think '&&' should replace '||'
> LogSyncerThread not getting shutdown waiting for the interrupted flag
> ---------------------------------------------------------------------
>
> Key: HBASE-5243
> URL: https://issues.apache.org/jira/browse/HBASE-5243
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.5
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.1, 0.90.6
>
> Attachments: HBASE-5243_0.90.patch
>
>
> In the LogSyncer run() we keep looping till this.isInterrupted flag is set.
> But in some cases the DFSclient is consuming the Interrupted exception. So
> we are running into infinite loop in some shutdown cases.
> I would suggest that as we are the ones who tries to close down the
> LogSyncerThread we can introduce a variable like
> Close or shutdown and based on the state of this flag along with
> isInterrupted() we can make the thread stop.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
