[ 
https://issues.apache.org/jira/browse/HBASE-19181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239016#comment-16239016
 ] 

Duo Zhang commented on HBASE-19181:
-----------------------------------

And in the code below we cast WAL to AbstractFSWAL, so why not also use 
AbstractFSWAL here?

And the {{hlog}} is a class member variable but is only used locally in one 
method, can change it to a local variable? Or just remove it? Seems it is only 
used to do logging but I'm a little confused. We request rolling on a list of 
WALs but the log is only for the default WAL?

Thanks.

> LogRollBackupSubprocedure will fail if we use AsyncFSWAL instead of FSHLog
> --------------------------------------------------------------------------
>
>                 Key: HBASE-19181
>                 URL: https://issues.apache.org/jira/browse/HBASE-19181
>             Project: HBase
>          Issue Type: Bug
>          Components: backup&restore
>            Reporter: Duo Zhang
>            Priority: Major
>
> In the RSRollLogTask it will cast a WAL to FSHLog.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to