[ https://issues.apache.org/jira/browse/HBASE-19160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239421#comment-16239421 ]
Hadoop QA commented on HBASE-19160: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 4m 43s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 14 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 27s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 21s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 45s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m 34s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 8m 51s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 57s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 1m 50s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} scalac {color} | {color:green} 3m 38s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 29s{color} | {color:red} hbase-common: The patch generated 1 new + 213 unchanged - 1 fixed = 214 total (was 214) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 37s{color} | {color:red} hbase-client: The patch generated 3 new + 49 unchanged - 3 fixed = 52 total (was 52) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 21s{color} | {color:red} hbase-server: The patch generated 9 new + 956 unchanged - 11 fixed = 965 total (was 967) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 20s{color} | {color:red} hbase-mapreduce: The patch generated 1 new + 48 unchanged - 1 fixed = 49 total (was 49) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m 37s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 54m 27s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 1m 34s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 13s{color} | {color:green} hbase-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 43s{color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red}111m 48s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m 51s{color} | {color:green} hbase-mapreduce in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 33s{color} | {color:green} hbase-it in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 29s{color} | {color:green} hbase-spark in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 55s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}234m 47s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 | | JIRA Issue | HBASE-19160 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12896103/HBASE-19160.v3.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile scalac scaladoc | | uname | Linux fa656aee7f79 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 3a0f59d031 | | maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) | | Default Java | 1.8.0_151 | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/9629/artifact/patchprocess/diff-checkstyle-hbase-common.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/9629/artifact/patchprocess/diff-checkstyle-hbase-client.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/9629/artifact/patchprocess/diff-checkstyle-hbase-server.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/9629/artifact/patchprocess/diff-checkstyle-hbase-mapreduce.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/9629/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/9629/testReport/ | | modules | C: hbase-common hbase-client hbase-server hbase-mapreduce hbase-it hbase-spark U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/9629/console | | Powered by | Apache Yetus 0.6.0 http://yetus.apache.org | This message was automatically generated. > Re-expose CellComparator > ------------------------ > > Key: HBASE-19160 > URL: https://issues.apache.org/jira/browse/HBASE-19160 > Project: HBase > Issue Type: Bug > Affects Versions: 2.0.0-alpha-4 > Reporter: Mike Drob > Assignee: Mike Drob > Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19160.patch, HBASE-19160.v2.patch, > HBASE-19160.v3.patch, HBASE-19160.v4.patch > > > On HBASE-18995 we moved a bunch of public methods to Private places. This > inadvertently breaks donwstream consumers. Let's see if we can ease up on > some of the lockdown and make life easier for them. > Copying [~ram_krish]'s previous analysis: > {quote} > I read the Crunch projec't hbase-support related code. > -> It uses both CellUtil (Public exposed) and KeyValueUtil (@Private) classes > for helper methods. > -> All methods in CellUtil that are getting used are even now exposed in > branch-2's CellUtil and they are very common helper methods. So we are safe > here. > -> Wrt KeyValueUtil the API is createFirstOnRow(). It is used in test cases > and in some core code. In most of the places they are trying to create the > splitKeys from the region's start keys and that is also getting persisted. I > think here they can safely create a cell out of the given byte[] of the row. > But there is one place where they are trying to do some scanning on a > HFileScanner directly (@Private) scanner. So this should be changed because > it is an internal interface for us. And on this scanner they have copied our > seekTo() code into their source files for some scanning purpose. In this code > they are actually using the KvUtil.createFirstOnRow() to seek to that first > cell of that row. > More over I think in branch-2 we are restricting even CPs from accessing some > of our internal scanners and they can only use InternalScanner interface. So > this code in crunch needs heavy refactoring to work with branch-2 in case > they want to fit into the Public/Private exposed semantics that HBase > presents to the downstreamers. > -> If still they want some APIs like this we can expose > CellUtil#createFirstOnRow, createLastOnRow, createFirstOnCol and > createLastOnCol at the maximum. I think others are not useful and are more > internal stuffs. > {quote} -- This message was sent by Atlassian JIRA (v6.4.14#64029)