[
https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-19194:
-----------------------------------
Status: Patch Available (was: Open)
> TestRSGroupsBase has some always false checks
> ---------------------------------------------
>
> Key: HBASE-19194
> URL: https://issues.apache.org/jira/browse/HBASE-19194
> Project: HBase
> Issue Type: Bug
> Components: rsgroup, test
> Reporter: Mike Drob
> Assignee: Andrew Purtell
> Priority: Minor
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19194-branch-1.patch
>
>
> Discovered via error-prone analysis:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile
> (default-testCompile) on project hbase-rsgroup: Compilation failure:
> Compilation failure:
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40]
> [CollectionIncompatibleType] Argument 'region' should not be passed to this
> method; its type RegionInfo is not compatible with its collection's type
> argument String
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65]
> [CollectionIncompatibleType] Argument 'targetRegion' should not be passed to
> this method; its type String is not compatible with its collection's type
> argument RegionInfo
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> {noformat}
> Both of these are checks to {{List<T>.contains}} with an element of the wrong
> type so they will always return false. The first is an optimization that we
> can probably live without (or short circuit on the Master, at least) the
> second is an assertion that will never fail, rendering the test ineffective.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
