[ https://issues.apache.org/jira/browse/HBASE-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191328#comment-13191328 ]
jirapos...@reviews.apache.org commented on HBASE-5240: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3594/ ----------------------------------------------------------- Review request for hbase. Summary ------- Just looking at http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/regionserver/InternalScanner.html. We don't know whether or not the results are appended to results list, or if we always clear it first. boolean next(List<KeyValue> results) Grab the next row's worth of values. boolean next(List<KeyValue> result, int limit) Grab the next row's worth of values with a limit on the number of values to return. Method Detail next boolean next(List<KeyValue> results) throws IOException Grab the next row's worth of values. Parameters: results - return output array Returns: true if more rows exist after this one, false if scanner is done Throws: IOException - e next boolean next(List<KeyValue> result, int limit) throws IOException Grab the next row's worth of values with a limit on the number of values to return. Parameters: result - return output array limit - limit on row count to get Returns: true if more rows exist after this one, false if scanner is done Throws: IOException - e This addresses bug HBASE-5240. https://issues.apache.org/jira/browse/HBASE-5240 Diffs ----- src/main/java/org/apache/hadoop/hbase/regionserver/InternalScanner.java 0f5f36c Diff: https://reviews.apache.org/r/3594/diff Testing ------- Thanks, Alex > HBase internalscanner.next javadoc doesn't imply whether or not results are > appended or not > ------------------------------------------------------------------------------------------- > > Key: HBASE-5240 > URL: https://issues.apache.org/jira/browse/HBASE-5240 > Project: HBase > Issue Type: Bug > Reporter: Alex Newman > Assignee: Alex Newman > Attachments: > 0001-HBASE-5240.-HBase-internalscanner.next-javadoc-doesn.patch > > > Just looking at > http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/regionserver/InternalScanner.html. > We don't know whether or not the results are appended to results list, or if > we always clear it first. > boolean next(List<KeyValue> results) > Grab the next row's worth of values. > boolean next(List<KeyValue> result, int limit) > Grab the next row's worth of values with a limit on the number of > values to return. > > Method Detail > next > boolean next(List<KeyValue> results) > throws IOException > Grab the next row's worth of values. > Parameters: > results - return output array > Returns: > true if more rows exist after this one, false if scanner is done > Throws: > IOException - e > next > boolean next(List<KeyValue> result, > int limit) > throws IOException > Grab the next row's worth of values with a limit on the number of values > to return. > Parameters: > result - return output array > limit - limit on row count to get > Returns: > true if more rows exist after this one, false if scanner is done > Throws: > IOException - e -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira