[
https://issues.apache.org/jira/browse/HBASE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mubarak Seyed updated HBASE-5189:
---------------------------------
Attachment: HBASE-5189.trunk.v2.patch
If we move getMetrics().incrementSplitFailureCount() before rollback() and if
rollback() returns false (or) throws RuntimeException then we don't need to
increment split failure count as RS is going to abort itself.
The one place which needs to call getMetrics().incrementSplitFailureCount() is
catch block
{code}
} catch (IOException ex) {
LOG.error("Split failed " + this, RemoteExceptionHandler
.checkIOException(ex));
this.server.getMetrics().incrementSplitFailureCount();
server.checkFileSystem();
{code}
as rollback() throws IOException.
The attached patch (HBASE-5189.trunk.v2.patch) updates the patch.
Thanks.
> Add metrics to keep track of region-splits in RS
> ------------------------------------------------
>
> Key: HBASE-5189
> URL: https://issues.apache.org/jira/browse/HBASE-5189
> Project: HBase
> Issue Type: Improvement
> Components: metrics, regionserver
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Mubarak Seyed
> Assignee: Mubarak Seyed
> Priority: Minor
> Labels: noob
> Attachments: HBASE-5189.trunk.v1.patch, HBASE-5189.trunk.v2.patch
>
>
> For write-heavy workload with region-size 1 GB, region-split is considerably
> high. We do normally grep the NN log (grep "mkdir*.split" NN.log | sort |
> uniq -c) to get the count.
> I would like to have a counter incremented each time region-split execution
> succeeds and this counter exposed via the metrics stuff in HBase.
> - regionSplitSuccessCount
> - regionSplitFailureCount (will help us to correlate the timestamp range in
> RS logs across all RS)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
