[ https://issues.apache.org/jira/browse/HBASE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191657#comment-13191657 ]
Hadoop QA commented on HBASE-5230: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12511585/Don-t-cache-data-blocks-on-compaction-2012-01-23_15_27_23.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -145 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 84 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplication org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.master.TestSplitLogManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/843//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/843//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/843//console This message is automatically generated. > Unit test to ensure compactions don't cache data on write > --------------------------------------------------------- > > Key: HBASE-5230 > URL: https://issues.apache.org/jira/browse/HBASE-5230 > Project: HBase > Issue Type: Test > Reporter: Mikhail Bautin > Assignee: Mikhail Bautin > Priority: Minor > Attachments: D1353.1.patch, D1353.2.patch, D1353.3.patch, > D1353.4.patch, > Don-t-cache-data-blocks-on-compaction-2012-01-21_00_53_54.patch, > Don-t-cache-data-blocks-on-compaction-2012-01-23_10_23_45.patch, > Don-t-cache-data-blocks-on-compaction-2012-01-23_15_27_23.patch > > > Create a unit test for HBASE-3976 (making sure we don't cache data blocks on > write during compactions even if cache-on-write is enabled generally > enabled). This is because we have very different implementations of > HBASE-3976 without HBASE-4422 CacheConfig (on top of 89-fb, created by Liyin) > and with CacheConfig (presumably it's there but not sure if it even works, > since the patch in HBASE-3976 may not have been committed). We need to create > a unit test to verify that we don't cache data blocks on write during > compactions, and resolve HBASE-3976 so that this new unit test does not fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira