[
https://issues.apache.org/jira/browse/HBASE-19311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260252#comment-16260252
]
Appy commented on HBASE-19311:
------------------------------
Reason makes sense. Had a very quick look. Some high level comments.
----
Do we need two tools? Maybe TestAcidGuarantees.java can be plan java unit test
now?
----
All our tools (unless they are very old and no one touched them) extend
AbstractHBaseTool now instead of directly extending Tool since the former takes
care of bunch of boilerplate work. Let's do the same here?
----
{quote}
util = getTestingUtil(getConf());
util.initializeCluster(SERVER_COUNT);
conf = getConf();
- conf.set(HConstants.HREGION_MEMSTORE_FLUSH_SIZE, String.valueOf(128*1024));
+ conf.set(HConstants.HREGION_MEMSTORE_FLUSH_SIZE, String.valueOf(128 *
1024));
// prevent aggressive region split
conf.set(HConstants.HBASE_REGION_SPLIT_POLICY_KEY,
- ConstantSizeRegionSplitPolicy.class.getName());
- this.setConf(util.getConfiguration());
+ ConstantSizeRegionSplitPolicy.class.getName());
- // replace the HBaseTestingUtility in the unit test with the integration
test's
- // IntegrationTestingUtility
- tag = new
TestAcidGuarantees(CompactingMemStore.COMPACTING_MEMSTORE_TYPE_DEFAULT);
- tag.setHBaseTestingUtil(util);
+ this.setConf(util.getConfiguration());
+ tool = new AcidGuaranteesTestTool();
+ tool.setConf(conf);
{quote}
That's confusing. Aren't {{conf=getConf()}} and {{util.getConfiguration()}}
same after we have done {{ util = getTestingUtil(getConf());}}.
> Promote TestAcidGuarantees to LargeTests and start mini cluster once to make
> it faster
> --------------------------------------------------------------------------------------
>
> Key: HBASE-19311
> URL: https://issues.apache.org/jira/browse/HBASE-19311
> Project: HBase
> Issue Type: Improvement
> Components: test
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Attachments: HBASE-19311.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
