[
https://issues.apache.org/jira/browse/HBASE-19342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266345#comment-16266345
]
Chia-Ping Tsai commented on HBASE-19342:
----------------------------------------
The mini cluster created by TestTableBasedReplicationSourceManagerImpl will
influence the global metrics so the patch make the following changes to
stabilize the tests.
# wait the replication table to be created. Otherwise, it is hard to assure the
correct metrics in test case
# ReplicationSourceManager add the peer to source list before updating the
related metrics, and consequently the metrics we get may be stale even though
the peer is in the source list. The patch add a condition check in {{startup}}
as it is executed after the metrics update.
I run the patch 50 times locally. All passed. Our QA has some trouble so I
don't click the "submit patch"
[~ashu210890] Would you please take a look?
> fix TestTableBasedReplicationSourceManagerImpl#testRemovePeerMetricsCleanup
> ---------------------------------------------------------------------------
>
> Key: HBASE-19342
> URL: https://issues.apache.org/jira/browse/HBASE-19342
> Project: HBase
> Issue Type: Test
> Reporter: Chia-Ping Tsai
> Assignee: Chia-Ping Tsai
> Attachments: HBASE-19342.v0.patch
>
>
> It is number one in [flaky
> tests|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html].
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
